[🐴] Additional tweaks to the message list #4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4075.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp3du7uct0pc73eljv6g. |
haileyok
commented
May 17, 2024
Comment on lines
-74
to
-90
| const [hasInitiallyRendered, setHasInitiallyRendered] = React.useState(false) | ||
|
|
||
| // HACK: Because we need to scroll to the bottom of the list once initial items are added to the list, we also have | ||
| // to take into account that scrolling to the end of the list on native will happen asynchronously. This will cause | ||
| // a little flicker when the items are first renedered at the top and immediately scrolled to the bottom. to prevent | ||
| // this, we will wait until the first render has completed to remove the loading overlay. | ||
| React.useEffect(() => { | ||
| if ( | ||
| !hasInitiallyRendered && | ||
| isConvoActive(convoState) && | ||
| !convoState.isFetchingHistory | ||
| ) { | ||
| setTimeout(() => { | ||
| setHasInitiallyRendered(true) | ||
| }, 15) | ||
| } | ||
| }, [convoState, hasInitiallyRendered]) |
There was a problem hiding this comment.
This was a nasty hack, time to rm
|
haileyok
commented
May 17, 2024
Comment on lines
-95
to
-106
| // Since we are using the native web methods for scrolling on `List`, we only use the reanimated `scrollTo` on native | ||
| const scrollToOffset = React.useCallback( | ||
| (offset: number, animated: boolean) => { | ||
| if (isWeb) { | ||
| flatListRef.current?.scrollToOffset({offset, animated}) | ||
| } else { | ||
| runOnUI(scrollTo)(flatListRef, 0, offset, animated) | ||
| } | ||
| }, | ||
| [flatListRef], | ||
| ) | ||
|
|
There was a problem hiding this comment.
In a galaxy far far away, developers have a Javascript ecosystem that interacts with native code fully synchronously, and they live very happily.
Alas, that is not our galaxy. There's some layouts that are not actually ready yet when we call scrollTo right now, particularly around sending a new message and expecting the view to scroll up. We've seen over the past week that the old way of doing things was solid, so let's return to that.
We will still use scrollTo for keyboard animation scrolling, because its 🔥🥵🔥 and doesn't cause problems.
another nit nit small annoyance add a comment only use `scrollTo` when necessary remove now unnecessary styles
Merged
estrattonbailey
approved these changes
May 17, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
* origin/main: [🐴] Don't always show notification for everything (#4083) [🐴] Additional tweaks to the message list (#4075) Conditionally load unreads (#4072) Revert "Aggregate quickly-sent messages into batches (#4061)" (#4069) 100% Real Deal™ (#4070) [🐴] 60 FPS Keyboard (#4066) Fix delete message error (#4065) Aggregate quickly-sent messages into batches (#4061) [🐴] Input hover and focus styles (#4064) fix typo (#4060) Fix error styles (#4063) Reset leave chat optimistic update if fails (#4058) don't show individual labels on own profile, only "have been placed..." (#4057) [🐴] Tweak header styles (#4053)
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
* origin/main: [🐴] NUX (#4062) [🐴] Reduce header size (#4078) [🐴] Don't always show notification for everything (#4083) [🐴] Additional tweaks to the message list (#4075) Conditionally load unreads (#4072) Revert "Aggregate quickly-sent messages into batches (#4061)" (#4069) 100% Real Deal™ (#4070) [🐴] 60 FPS Keyboard (#4066) Fix delete message error (#4065) Aggregate quickly-sent messages into batches (#4061) [🐴] Input hover and focus styles (#4064) fix typo (#4060) Fix error styles (#4063) Reset leave chat optimistic update if fails (#4058) don't show individual labels on own profile, only "have been placed..." (#4057) [🐴] Tweak header styles (#4053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.