[🐴] 60 FPS Keyboard #4066
Merged
[🐴] 60 FPS Keyboard #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4066.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp39316ct0pc73elet90. |
haileyok
commented
May 16, 2024
Comment on lines
-226
to
-232
| requestAnimationFrame(() => { | ||
| if (isMomentumScrolling.value) return | ||
|
|
||
| flatListRef.current?.scrollToEnd({animated: true}) | ||
| isMomentumScrolling.value = true | ||
| }) | ||
| }, [isMomentumScrolling]) |
There was a problem hiding this comment.
Since this is happening sync now, we don't need to use requestAnimationFrame here.
haileyok
commented
May 16, 2024
| } | ||
|
|
||
| keyboardIsOpening.value = now !== prev | ||
| scrollTo(flatListRef, 0, contentHeight.value + now, false) |
There was a problem hiding this comment.
Running scrollTo here within useAnimatedReaction will perform the scroll sync.
haileyok
commented
May 16, 2024
| @@ -119,6 +131,7 @@ export function MessagesList() { | |||
| // really large - and the normal chat behavior would be to still scroll to the end if it's only one | |||
| // message - we ignore this rule if there's only one additional message | |||
| if ( | |||
| !keyboardIsOpening.value && | |||
There was a problem hiding this comment.
We let the animated reaction handle this now, so never scroll on content size changes due to the keyboard opening.
|
mozzius
approved these changes
May 17, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
* origin/main: [🐴] Don't always show notification for everything (#4083) [🐴] Additional tweaks to the message list (#4075) Conditionally load unreads (#4072) Revert "Aggregate quickly-sent messages into batches (#4061)" (#4069) 100% Real Deal™ (#4070) [🐴] 60 FPS Keyboard (#4066) Fix delete message error (#4065) Aggregate quickly-sent messages into batches (#4061) [🐴] Input hover and focus styles (#4064) fix typo (#4060) Fix error styles (#4063) Reset leave chat optimistic update if fails (#4058) don't show individual labels on own profile, only "have been placed..." (#4057) [🐴] Tweak header styles (#4053)
estrattonbailey
added a commit
that referenced
this pull request
May 17, 2024
* origin/main: [🐴] NUX (#4062) [🐴] Reduce header size (#4078) [🐴] Don't always show notification for everything (#4083) [🐴] Additional tweaks to the message list (#4075) Conditionally load unreads (#4072) Revert "Aggregate quickly-sent messages into batches (#4061)" (#4069) 100% Real Deal™ (#4070) [🐴] 60 FPS Keyboard (#4066) Fix delete message error (#4065) Aggregate quickly-sent messages into batches (#4061) [🐴] Input hover and focus styles (#4064) fix typo (#4060) Fix error styles (#4063) Reset leave chat optimistic update if fails (#4058) don't show individual labels on own profile, only "have been placed..." (#4057) [🐴] Tweak header styles (#4053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.