Change many border widths from 1 to hairlineWidth
#4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4294.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpcjfm5ds78s73d4gr9g. |
haileyok
commented
May 31, 2024
| <ViewHeader | ||
| title={_(msg`Notifications`)} | ||
| canGoBack={false} | ||
| showBorder={true} |
There was a problem hiding this comment.
had to add border here, since previously it was on the top of the post item.
haileyok
commented
May 31, 2024
| @@ -27,6 +33,7 @@ let FeedSlice = ({slice}: {slice: FeedPostSlice}): React.ReactNode => { | |||
| moderation={slice.items[0].moderation} | |||
| isThreadParent={isThreadParentAt(slice.items, 0)} | |||
| isThreadChild={isThreadChildAt(slice.items, 0)} | |||
| hideTopBorder={hideTopBorder} | |||
There was a problem hiding this comment.
In feeds, we use FeedSlice instead of FeedItem directly. So, we need to tell the first item in the feed slice to not display the border if it is also the first item in renderItem.
haileyok
commented
May 31, 2024
| @@ -75,6 +82,7 @@ let FeedSlice = ({slice}: {slice: FeedPostSlice}): React.ReactNode => { | |||
| isThreadLastChild={ | |||
| isThreadChildAt(slice.items, i) && slice.items.length === i + 1 | |||
| } | |||
| hideTopBorder={hideTopBorder && i === 0} | |||
haileyok
commented
May 31, 2024
Comment on lines
+184
to
+185
| initialNumToRender={initialNumToRender} | ||
| windowSize={11} |
There was a problem hiding this comment.
We were missing some FlatList perf props here. Removed the above comment after adding this, since I wasn't even getting the warning previously anyway.
|
gaearon
approved these changes
May 31, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 31, 2024
* origin/main: (51 commits) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) play haptics before closing modal (#4283) match loadmore position to fab (#4280) Composer - Use sheet presentation on iOS (#4278) don't maintain position whenever there are no parents (#4277) Fix native translations on iOS 17.5.1 (#4282) ...
estrattonbailey
added a commit
that referenced
this pull request
May 31, 2024
* origin/main: (37 commits) fix accessibility label in notifications (#4305) [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229) Tweak avi follow button styles (#4304) [🐴] Embed backwards compat (#4302) [🐴] Add labels to chats (#4293) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Note: We are changing #2090 to round to 0.5 instead, since hairline is 0.5 pixels.
Hairline width looks a lot better in many places.
I also adjusted a few more things while going through the codebase, see individual comments for details.
Test Plan
Honestly, I think I've hit everything visually by clicking through the app on a simulator, though I'm not certain. Will need to continue using it.