Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer - Use sheet presentation on iOS #4278

Merged
merged 3 commits into from
May 30, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented May 30, 2024

  • Uses formSheet presentation iOS, which speeds up the animation and allows swipe-to-dismiss
    • I figured out a way to keep the black backdrop without needing to impact the rest of the app
  • Cleans up a bunch of the janky spacing in the composer top bar (turns out we were adding 15px padding and then -14px margin? lol)
  • Make composer generally a little more compact, thanks to Composer - only show divider when scrolled #4275 making the whitespace less necessary
Simulator.Screen.Recording.-.iPhone.15.-.2024-05-30.at.10.57.12.mp4

Copy link

render bot commented May 30, 2024

Copy link

github-actions bot commented May 30, 2024

Old size New size Diff
7.23 MB 7.23 MB -67 B (-0.00%)

@mozzius mozzius force-pushed the samuel/composer-sheet-presentation branch from 2fa7b59 to e51916a Compare May 30, 2024 11:36
@gaearon gaearon merged commit 3bdceac into main May 30, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (51 commits)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  play haptics before closing modal (#4283)
  match loadmore position to fab (#4280)
  Composer - Use sheet presentation on iOS (#4278)
  don't maintain position whenever there are no parents (#4277)
  Fix native translations on iOS 17.5.1 (#4282)
  ...
estrattonbailey pushed a commit that referenced this pull request May 31, 2024
* use sheet presentation + tweak spacing

* line up elements + add hitslop to cancel

* fixing spacing on replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants