Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer - fix modals, and other tweaks #4298

Merged
merged 9 commits into from
May 31, 2024
Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented May 31, 2024

  • Fix modals
    • iOS: wrap modals in <FullScreenOverlay> from React Native Screens
    • Android: wrap modal content in <GestureHandlerRootView> and put providers inside modal
  • Animate the language dropdown
  • Fix content appearing behind composer bottom bar (adjust keyboard offset + add background)
  • Line up content of bottom bar visually (gallery icon is now 16px from the edge, rather than the whole button)
  • Reduce size of threadgate button and line it up visually as well
Screenshot 2024-05-31 at 11 29 35
  • Make top border go across the whole screen now that it only appears on scroll
  • Move errors/alt text reminder inside of the header above border
Screenshot 2024-05-31 at 10 41 43
  • Make border colours consistent now that the whole app is hairlineWidth

Test plan

  1. Make sure all the modals work as expected on all platforms. Composer ones especially, but double check some other ones on iOS since I did make a slight change there
  2. Make sure voiceover still works on iOS!
  3. Have a check of the other tweaks

Copy link

render bot commented May 31, 2024

Copy link

github-actions bot commented May 31, 2024

Old size New size Diff
7.24 MB 7.24 MB -302 B (-0.00%)

@gaearon gaearon merged commit 05b55c1 into main May 31, 2024
6 checks passed
@gaearon gaearon deleted the samuel/composer-modals branch May 31, 2024 12:02
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (51 commits)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  play haptics before closing modal (#4283)
  match loadmore position to fab (#4280)
  Composer - Use sheet presentation on iOS (#4278)
  don't maintain position whenever there are no parents (#4277)
  Fix native translations on iOS 17.5.1 (#4282)
  ...
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (37 commits)
  fix accessibility label in notifications (#4305)
  [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229)
  Tweak avi follow button styles (#4304)
  [🐴] Embed backwards compat (#4302)
  [🐴] Add labels to chats (#4293)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants