Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFP follow button: profile shadows #4265

Merged
merged 1 commit into from
May 31, 2024
Merged

PFP follow button: profile shadows #4265

merged 1 commit into from
May 31, 2024

Conversation

estrattonbailey
Copy link
Member

Stacked on #3560

Copy link

github-actions bot commented May 29, 2024

Old size New size Diff
7.24 MB 7.24 MB 1.69 KB (0.02%)

@estrattonbailey estrattonbailey force-pushed the eric/pfp-follow-shadow branch from ee29d97 to 0cf9089 Compare May 31, 2024 03:01
Base automatically changed from samuel/pfp-follow-btn to main May 31, 2024 04:05
@gaearon gaearon force-pushed the eric/pfp-follow-shadow branch from 0cf9089 to a9d990b Compare May 31, 2024 04:36
Copy link

render bot commented May 31, 2024

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit worried about added traversals but @haileyok tested on low end android on large threads and it seemed ok. let's give this a go

@gaearon gaearon merged commit d614f6c into main May 31, 2024
9 checks passed
@gaearon gaearon deleted the eric/pfp-follow-shadow branch May 31, 2024 04:56
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (51 commits)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  play haptics before closing modal (#4283)
  match loadmore position to fab (#4280)
  Composer - Use sheet presentation on iOS (#4278)
  don't maintain position whenever there are no parents (#4277)
  Fix native translations on iOS 17.5.1 (#4282)
  ...
estrattonbailey added a commit that referenced this pull request May 31, 2024
* origin/main: (37 commits)
  fix accessibility label in notifications (#4305)
  [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229)
  Tweak avi follow button styles (#4304)
  [🐴] Embed backwards compat (#4302)
  [🐴] Add labels to chats (#4293)
  [🐴] Option to share via chat in post dropdown (#4231)
  [🐴] Record message (#4230)
  [🐴] send record via link in text (Record DMs - base PR) (#4227)
  Use new icons on notifications screen (#4299)
  Composer - fix modals, and other tweaks (#4298)
  Shadows (#4265)
  Change many border widths from `1` to `hairlineWidth` (#4294)
  Add follow button to feed item avatar (#3560)
  Disable non-deterministic flaky test (#4295)
  Don't log downsample warning when unnecessary (#4291)
  [Statsig] Sample noisy events (#4288)
  Bump FontAwesome (#4285)
  Fix scrolling for labeler profiles (#4286)
  Reduce Threadgate button size (#4287)
  put dropdown in fullscreenoverlay on iOS (#4284)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants