don't maintain position whenever there are no parents #4277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4277.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpc2hmun7f5s73aqmd70. |
|
gaearon
approved these changes
May 30, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 31, 2024
* origin/main: (51 commits) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) play haptics before closing modal (#4283) match loadmore position to fab (#4280) Composer - Use sheet presentation on iOS (#4278) don't maintain position whenever there are no parents (#4277) Fix native translations on iOS 17.5.1 (#4282) ...
estrattonbailey
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In #4254, we removed the
ViewHeaderfrom the items given toFlatListand instead placed it outside theFlatList. In doing so, we removed the first element of our array.Now, whenever we open a post that has no parents but has a link card inside of it, we see that the list is maintaining the position of the root post - since that is the first item in the list that can be "latched onto".
RocketSim_Recording_iPhone_15_Pro_6.1_2024-05-30_00.09.24.mp4
The solution is to set the
maintainVisibleContentPositionprop toundefinedwhenever we know there are no parents that could cause a layout jump.Test Plan
Visit this post and test opening the quoted post. There should be no layout jump. https://bsky.app/profile/ellyzoe.bsky.social/post/3ktlkoamoko2h
RocketSim_Recording_iPhone_15_Pro_6.1_2024-05-30_00.20.26.mp4