[🐴] add emoji multiplier prop to RichText and bump it up for DMs #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4229.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpa38mfjbltc73fp9i60. |
|
estrattonbailey
approved these changes
May 30, 2024
* origin/main: (51 commits) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) play haptics before closing modal (#4283) match loadmore position to fab (#4280) Composer - Use sheet presentation on iOS (#4278) don't maintain position whenever there are no parents (#4277) Fix native translations on iOS 17.5.1 (#4282) ...
estrattonbailey
requested changes
May 31, 2024
estrattonbailey
approved these changes
May 31, 2024
Comment on lines
+252
to
+253
| text.length <= 15 && | ||
| /^[\p{Emoji_Presentation}\p{Extended_Pictographic}]+$/u.test(text) |
There was a problem hiding this comment.
Supports large emojis like 🧑🏻❤️💋🧑🏼 which is 15 and captures a few more emoji like some flags 🇿🇼
There was a problem hiding this comment.
If we wanted to do this right we'd count graphemes, but unsure it's worth the perf
There was a problem hiding this comment.
Correction: 🧑🏻❤️💋🧑🏼 is not caught by the regex, but I'll leave the limit here anyway since even something like 🐴 is length 2.
estrattonbailey
added a commit
that referenced
this pull request
May 31, 2024
* origin/main: (37 commits) fix accessibility label in notifications (#4305) [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229) Tweak avi follow button styles (#4304) [🐴] Embed backwards compat (#4302) [🐴] Add labels to chats (#4293) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emojis are now 1.85 times bigger than whatever the text size was meant to be, rather than a static 26px. This should mostly result in the same size.
In DMs, the multiplier is 3x
Before
After
Test plan
Check it looks ok, including on existing areas that have rich text. Make sure to test it looks ok on Windows, since their emoji can be a bit funny looking