Add follow button to feed item avatar #3560
Conversation
mozzius
commented
Apr 15, 2024
•
mozzius
commented
|
|
Does this mean there would be a mini follow button as part of every avatar on every feed (for users that you don't already follow)? Or have I misunderstood? 🤔 If I have understood correctly, I feel like this will generate an awful lot of unintended follows when people tap or click it by mistake, without actually meaning to follow the user in question. Also, again just my personal opinion, but I feel like this will make the Bluesky interface look rather ugly and that it will be poorly received by users 😕 |
|
As an alternative suggestion, what about adding a bottom sheet that opens when long-pressing the user's avatar? This could show exactly the same content as the hover cards on web do. To follow a user, you would simply long-press the pfp and then tap the Follow button. |
We're talking about how to handle this properly. My personal preference would be an inline dropdown (even on mobile) that has "Go to profile" and "Follow" as options. We would need to cook up that UI behavior.
Part of the goal is also to introduce a visual indicator of whether you're following the person. |
|
Thank you for the clarification on what's planned and some of the thinking behind it. |
|
Sure. More than happy to hear more suggestions or reactions to it. Don't want to do something folks won't be into. |
|
A couple of tweaks:
We're also going to put this behind a feature gate so we can test it internally and then do an experimental rollout. |
|
Your Render PR Server URL is https://social-app-pr-3560.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cohdb5v109ks73f5otv0. |
I think having a follow confirmation is essential, so thanks for adding that 🙏 And the smaller, less obtrusive indicator is welcome too.
That's a good way to proceed 👍 |
Should I be able to test this out by logging in here? When I do, it looks the same as Bluesky normally does, there's no indicator on pfps of users I don't follow. Or maybe because it's behind a feature gate that doesn't work for this PR? 🤔 |
This PR is iOS/Android only |
That would explain it 😅 |
mozzius
force-pushed
the
samuel/pfp-follow-btn
branch
from
7e41902
to
272dab6
Compare
|
Also added it to post thread items - only the secondary ones, since the main one will have a big "follow" button Threaded replies do not have it because they're too small
|
* origin/main: (392 commits) Remove old onboarding (#4224) Replace getAgent() with reading agent (#4243) Bump 1.85.0 (#4237) bump iOS target to `14.0` (#4238) set `onEndReachedThreshold` to `2` for notifications (#4235) Run intl extract (#4217) Updated Japanese translation (#4144) Updated Chinese translation (#4147) Update Korean localization (#4148) Update catalan messages.po (#4149) Update Indonesian translation (#4165) [🐴] update convo list from message bus (#4189) Recover from initial failed firehose state (#4211) Move ALT indicator right and shrink it a bit (#4213) Make sure failed messages enter error state (#4210) [🐴] Don't submit the message on return press when on a phone (web input) (#4203) Include feedContext in DOM as data- (#4206) Improve moderation behaviors: show alert/inform sources and improve UX around threads (#3677) Privileged app passwords (#4200) [🐴] Overfetch follow for default new dialog state (#4205) ...
| }, | ||
| ] | ||
|
|
||
| return gate('show_avi_follow_button') && hasSession ? ( |
There was a problem hiding this comment.
note this generally should be the other way around — we should delay calling gate until we have to make a decision. so it should be the last check
* origin/main: (51 commits) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) play haptics before closing modal (#4283) match loadmore position to fab (#4280) Composer - Use sheet presentation on iOS (#4278) don't maintain position whenever there are no parents (#4277) Fix native translations on iOS 17.5.1 (#4282) ...
* origin/main: (37 commits) fix accessibility label in notifications (#4305) [🐴] add emoji multiplier prop to RichText and bump it up for DMs (#4229) Tweak avi follow button styles (#4304) [🐴] Embed backwards compat (#4302) [🐴] Add labels to chats (#4293) [🐴] Option to share via chat in post dropdown (#4231) [🐴] Record message (#4230) [🐴] send record via link in text (Record DMs - base PR) (#4227) Use new icons on notifications screen (#4299) Composer - fix modals, and other tweaks (#4298) Shadows (#4265) Change many border widths from `1` to `hairlineWidth` (#4294) Add follow button to feed item avatar (#3560) Disable non-deterministic flaky test (#4295) Don't log downsample warning when unnecessary (#4291) [Statsig] Sample noisy events (#4288) Bump FontAwesome (#4285) Fix scrolling for labeler profiles (#4286) Reduce Threadgate button size (#4287) put dropdown in fullscreenoverlay on iOS (#4284) ...
