Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move feeds screen into common navigator, handle usages #4365

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

estrattonbailey
Copy link
Member

This PR removes the FeedsTab and places it with the Feeds screen in the common screens stack so that it's accessible from any other screen or tab navigator.

Copy link

render bot commented Jun 4, 2024

Copy link

github-actions bot commented Jun 4, 2024

Old size New size Diff
7.39 MB 7.39 MB 0 B (0.00%)

* Add link to feeds to home screen header

* Center logo

* Replace icons

* Tweak spacing

* Tweak spacing

* Swap icon, sizing

* Buttonize, size

* Make menu same alignment on all screens

* Remove FeedsTab support, enable drawer swipe on MessagesTab

* Add note

* Vertically align header

* Swap in Pin

* Use hashtag icon

* Remove png

* Fix reference
* origin/main: (54 commits)
  patch `expo-notifications` to clear badge (#4475)
  Revert to old modal on android (#4458)
  Sort profile feedgens by likes (#4380)
  Revert "Fix undefined block (#4471)" (#4472)
  Fix undefined block (#4471)
  Open convo menu when tapping on chat with deleted account (#4470)
  stop using `addPushTokenListener` (#4467)
  add hitslop to repost button (#4469)
  Add a loading indicator to notifications when loading latest (#4468)
  Visually improve the empty state of feeds (#4466)
  Give a meaningful error in the composer when replying to a deleted post (#4464)
  Fix: show known feed error UI more reliably (#4463)
  Only validate persisted data for existing users (#4465)
  Check `canAskAgain` for notification permissions (#4460)
  Add support for new-tab clicks on feeds (#4462)
  Override legacy language codes for indonesian, hebrew, and yiddish (#4461)
  Ungate mobile web notification badge (#4459)
  Fix (#4430): Use separate hooks for shell mode animated styles (#4451)
  Throttle instead of debounce (#4456)
  debounce refetching listconvos (#4455)
  ...
@pfrazee pfrazee merged commit 4b6609d into main Jun 11, 2024
6 checks passed
@pfrazee pfrazee deleted the feeds/navigation branch June 11, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants