Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show feedback for Follow button in interstitials #4738

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 5, 2024

  • Fix button feedback by adding another cache traversal for the shadow
  • Add a toast

Note the toast is added to a shared component that's also used by the starter packs, so individual Follow buttons also show toasts there too.

Test Plan

feedback.mov

Copy link

render bot commented Jul 5, 2024

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jul 5, 2024

Old size New size Diff
6.61 MB 6.61 MB -113 B (-0.00%)

@gaearon gaearon merged commit 09dfc9e into main Jul 5, 2024
6 checks passed
@gaearon gaearon deleted the fix-follow-btn branch July 5, 2024 19:17
estrattonbailey added a commit that referenced this pull request Jul 9, 2024
…cial-proof

* origin/main: (126 commits)
  Update README.md (#4394)
  tweak top padding external (#4755)
  change `contentVisibility` to `contain` (#4752)
  Fix RTL text rendering for display names (#4747)
  Reduce the size of the inner logo in the QR code (#4746)
  Fix misplaced '@' in RTL post meta. (#4531)
  Remove broken and void back button (#4744)
  Ensure `/start` navigates to `/starter-pack` when clicking a link internally (#4745)
  Add missing `to` in StarterPackScreen.tsx string (#4743)
  Video compression in composer (#4638)
  fix slop (#4739)
  Update stats
  Run intl:extract
  Update Japanese translation (#4665)
  Update Korean localization (#4646)
  Update Chinese Localization (#4695)
  Update catalan (#4702)
  Update Indonesian translation (#4706)
  Tweak checkmark size
  Show feedback for Follow button in interstitials (#4738)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants