Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change contentVisibility to contain #4752

Merged
merged 5 commits into from
Jul 8, 2024
Merged

change contentVisibility to contain #4752

merged 5 commits into from
Jul 8, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Jul 8, 2024

Why

We've ran into another weird quirk when using content-visiblity. Scroll views often don't resize whenever new items get added to the list, which is causing problems with onEndReached in the web implementation of FlatList. We're switching to contain: layout paint instead.

Test Plan

When opening the notifications tab on a large monitor, there shouldn't be chained requests for notifications.

@render Render
Copy link

render bot commented Jul 8, 2024

Your Render PR Server URL is https://social-app-pr-4752.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cq64h7hu0jms738lv69g.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Old size New size Diff
6.61 MB 6.61 MB 23 B (0.00%)

@gaearon
Copy link
Collaborator

gaearon commented Jul 8, 2024

we should rename the property maybe?

@haileyok
Copy link
Contributor Author

haileyok commented Jul 8, 2024 •
edited
Loading

Sure. I also changed containWeb to the more describe disableFullWindow with a little comment on usage so that it isn't redundant with this new prop. Checking real quick that it doesn't break anything.

Edit:
Tested, looks good. Going to ask some people if this also fixes that janky scroll stutter problem.

@haileyok haileyok merged commit a3c43a7 into main Jul 8, 2024
6 checks passed
@haileyok haileyok mentioned this pull request Jul 8, 2024
Closed
estrattonbailey added a commit that referenced this pull request Jul 9, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into samuel/suggestions-so…
6ee5949 
…cial-proof

* origin/main: (126 commits)
  Update README.md (#4394)
  tweak top padding external (#4755)
  change `contentVisibility` to `contain` (#4752)
  Fix RTL text rendering for display names (#4747)
  Reduce the size of the inner logo in the QR code (#4746)
  Fix misplaced '@' in RTL post meta. (#4531)
  Remove broken and void back button (#4744)
  Ensure `/start` navigates to `/starter-pack` when clicking a link internally (#4745)
  Add missing `to` in StarterPackScreen.tsx string (#4743)
  Video compression in composer (#4638)
  fix slop (#4739)
  Update stats
  Run intl:extract
  Update Japanese translation (#4665)
  Update Korean localization (#4646)
  Update Chinese Localization (#4695)
  Update catalan (#4702)
  Update Indonesian translation (#4706)
  Tweak checkmark size
  Show feedback for Follow button in interstitials (#4738)
  ...
@haileyok haileyok deleted the hailey/contentvisibility branch September 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @gaearon