Move global "Sign out" out of the current account row

[gaearon]

Implements #4775

Our "Sign out" button applies to all accounts but pretends to apply just to the current one. This is deeply confusing. There are good reasons for it to apply to all accounts (avoids tricky "logged into some but not all" cases), but we need to visually communicate what the button is doing, and to discourage its use in cases where it's not needed (account switch).

We move the "Sign out" button below the account list. Individual accounts now always have the "..." with "Remove account" instead. (You should be able to remove the current account when you need to, which you couldn't before.)

One account:

Multiple accounts:

The new "Sign out multiple accounts" at the bottom is more explicit that it clears everything.

The problem with the old "Sign out" buttons was that they're very tempting to press when you want to switch accounts (you want to "sign out", right?) But that's actually counterproductive (it logs you out of everything). By removing the prominent Sign out call to action, we reduce the likelihood of making that mistake. If you're planning to give the device to somebody you don't trust, you can still sign out — but not piecemeal.

Alternatively, you can remove the account.

That would remove its tokens and its handle.

Initially I considered making it possible to sign out of some accounts but not others, but this is too confusing. It would still be possible to make a very bad mistake (signing out from one account while thinking you're signing out of all of them). And the mistake wouldn't even be obviously visible unless we add signed-in/out indication for each. A "remove" action is simpler.

Since it's now a bit more commonly displayed and it's a more destructive action in case you don't remember the handle, I've added a confirm prompt.

The lack of a separate "Sign out" option here feels like a regression, but if we left it, we'd be silently changing the behavior of a very important button. Also, it would still be ambiguous.

To sum up, we now consistently show:

• "Remove account" for each account (whether you have one or many)
  • I've added a prompt there to avoid accidental removals. Since remembering the handle can be tricky.
• "Sign out of all accounts" (shortened to "Sign out" when you have one) at the bottom that does the old thing.

Test Plan

Go through the flows. Verify they make sense with one or more accounts.

In the case of having just one account, it's basically the same but the button moved down and you're able to remove it now.

[render]

Your Render PR Server URL is https://social-app-pr-4941.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cqulfu3tq21c7391og7g.

[github-actions]

Old size	New size	Diff
7.09 MB	7.09 MB	902 B (0.01%)

---

[gaearon]

Hm I guess this lost the indication which one you're signed into.

[gaearon]

Added "Other accounts" grouping to make it very clear which one you're signed in.

Alternatively we could do the checkmark. I don't love the one we're using though, and we'd have to place it next to the dropdown — don't want to remove the ability to remove the last remaining account.

We could also have some text label on the right liked "Signed in".

[mozzius]

Checked for both single and multiple accounts, looks good

[pfrazee]

Added a small spacing tweak. LGTM!