Add list hidden screen
#4958
Merged
Add list hidden screen
#4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4958.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr1uelrtq21c73e8q260. |
haileyok
commented
Aug 20, 2024
| } | ||
| } | ||
| }, [navigation, canGoBack, onGoBackProp]) | ||
| const goBack = useGoBack(onGoBack) |
There was a problem hiding this comment.
No change, just extracting this function to a reusable hook.
|
|
We should also hide the list name under Moderation > Lists in user settings for subscribers |
Co-authored-by: Hailey <me@haileyok.com>
I'm going to PR this separately. |
estrattonbailey
approved these changes
Aug 20, 2024
* cleanup * hide title of moderation list * temp * clean * add margin * loosen types * tweak type * add an `override` prop to `hider` * Props switcheroo --------- Co-authored-by: Eric Bailey <git@esb.lol>
estrattonbailey
approved these changes
Aug 20, 2024
estrattonbailey
added a commit
that referenced
this pull request
Aug 20, 2024
* origin/main: Add `list hidden` screen (#4958)
estrattonbailey
added a commit
that referenced
this pull request
Aug 21, 2024
* origin/main: (50 commits) Add `list hidden` screen (#4958) Expose more methods, support disabled items (#4954) Expose more props from button (#4953) Fix orphaned feed slices, handle blocks (#4944) Tweak `expo-modules-core` hack patch (#4955) [Experiment] Always show bottom bar (#4946) Revert "[Video] Download videos" (#4945) Move global "Sign out" out of the current account row (#4941) Hack patch for testing OTA update crash behavior (#4942) [Video] Download videos (#4886) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Whenever a list gets a
!hideflag applied to it, the app should prevent users from viewing the list. However, users do still need to be able to remove the list from their pins or subscribed mod lists. Let's add a screen to do that.We also were not hiding the list name from the title, since it was being set in
useSetTitle(). I removed that, and it will showList Hiddenin those cases.How
Whenever viewing the list, a screen will be shown telling the user the list has been hidden. If they are the owner, they will have the option to delete the list. If they are subscribed to the moderation list, they will be able to unsubscribe. And if they have the list saved or in their pins, they'll be able to remove it from there.
Test Plan
Two test lists that I have made: http://localhost:19006/profile/haileyok.com/lists/3l247irgjn62r and http://localhost:19006/profile/haileyok.com/lists/3l24csobejw2r
You can also test deleting the list by changing the
isHiddenvariable on line 151 inProfileList.tsxtotrue.Whenever you are the creator of the list, you should be able to still tap into the list with "Show anyway".
Non-creators should not be able to see the list.
However, if you are not the creator and you have saved or subscribed to the list, you should be given the ability to unsave/unsubscribe from that list.