[Video] add scrubber to the web player #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4943.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqv5fvqj1k6c73bbotrg. |
|
gaearon
reviewed
Aug 16, 2024
src/view/com/util/post-embeds/VideoEmbedInner/VideoWebControls.tsx
Outdated
Show resolved
Hide resolved
mozzius
force-pushed
the
samuel/scrubber
branch
from
b10ca61 to
a833028
Compare
mozzius
commented
Aug 23, 2024
Comment on lines
474
to
486
| useEffect(() => { | ||
| // HACK: there's divergent browser behaviour about what to do when | ||
| // a pointerUp event is fired outside the element that captured the | ||
| // pointer. Firefox clicks on the element the mouse is over, so we have | ||
| // to make everything unclickable while seeking -sfn | ||
| if (isFirefox && scrubbing) { | ||
| document.body.classList.add('force-no-clicks') | ||
|
|
||
| return () => { | ||
| document.body.classList.remove('force-no-clicks') | ||
| } | ||
| } | ||
| }, [scrubbing]) |
There was a problem hiding this comment.
This was the least worst solution I could come up with for the firefox click issue
There was a problem hiding this comment.
I was actually able to break this if i take my cursor outside of the window while still pressing down. Can we prevent that from breaking?
haileyok
approved these changes
Aug 26, 2024
mozzius
commented
Aug 26, 2024
Comment on lines
+474
to
+484
| const abortController = new AbortController() | ||
| const {signal} = abortController | ||
| document.documentElement.addEventListener( | ||
| 'mouseleave', | ||
| () => { | ||
| isSeekingRef.current = false | ||
| onSeekEnd() | ||
| setScrubberActive(false) | ||
| }, | ||
| {signal}, | ||
| ) |
There was a problem hiding this comment.
@haileyok is the mouse leaving the window a firefox-only issue or should I apply this fix on all browsers?
There was a problem hiding this comment.
i assume it is just firefox yea. i couldn't get it to repro in chrome or safari.
There was a problem hiding this comment.
Ok cool, this fix should be good then
estrattonbailey
added a commit
that referenced
this pull request
Aug 29, 2024
* origin/main: (520 commits) Fix language filtering for feeds (#5026) Enable show_follow_back_label_v2 (#5022) Remove logging of following prefs (#5021) Remove new_user_guided_tour and tour code (#5023) [Video] Remove old env var (#5018) Profile screen performance tweak - Adjust initial num to render based on header height (#5005) [Video] Make compress/upload cancelable (#4996) [Video] Add uploaded video to post (#4884) [Video] Add `timeRemainingChange` event to `player` in `expo-video` (#5013) [Video] Lexicon implementation (#4881) Hide quote counts for quotegated posts (#5011) Ensure captcha verification code gets submitted in signup request (#5010) clean up languages (#5007) [Video] 🫧 Move logic around by platform (#5003) bump 1.91.0 (#5002) add indicator of time remaining (#5000) [Video] add scrubber to the web player (#4943) Release 1.90 prep (#4988) Use moderatePost_wrapped for post embeds (#4981) Update Indonesian translation (#4875) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-08-15.at.20.28.46.mov
Test plan
Known issueIf you mouseUp while the mouse is over a post (but not over the video), it'll navigate to the post.evt.preventDefault()doesn't prevent itSolved! We make everything unclickable while scrubbing 😅