Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide quote counts for quotegated posts #5011

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Aug 28, 2024

Copy link

render bot commented Aug 28, 2024

Copy link

Old size New size Diff
7.13 MB 7.13 MB 45 B (0.00%)

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have not tested but code lgtm

@estrattonbailey estrattonbailey merged commit b136c44 into main Aug 28, 2024
6 checks passed
@surfdude29
Copy link
Contributor

The number next to the repost button still includes the number of quote posts... when quote posts aren't being displayed, shouldn't the numbers of reposts match?

E.g. on the test post it looks like there are 21 reposts if you go by the number next to the repost button (because it includes the 14 ghost quotes) but there are actually only 7

IMG_7923

https://main.bsky.dev/profile/pfrazee.com/post/3l2shzxiref2u

However, maybe it's not worth worrying about as more people upgrade to 1.90 and there are fewer ghost quotes being created 🤷🏻‍♂️

estrattonbailey added a commit that referenced this pull request Aug 29, 2024
* origin/main: (520 commits)
  Fix language filtering for feeds (#5026)
  Enable show_follow_back_label_v2 (#5022)
  Remove logging of following prefs (#5021)
  Remove new_user_guided_tour and tour code (#5023)
  [Video] Remove old env var (#5018)
  Profile screen performance tweak - Adjust initial num to render based on header height (#5005)
  [Video] Make compress/upload cancelable (#4996)
  [Video] Add uploaded video to post (#4884)
  [Video] Add `timeRemainingChange` event to `player` in `expo-video` (#5013)
  [Video] Lexicon implementation (#4881)
  Hide quote counts for quotegated posts (#5011)
  Ensure captcha verification code gets submitted in signup request (#5010)
  clean up languages (#5007)
  [Video] 🫧 Move logic around by platform (#5003)
  bump 1.91.0 (#5002)
  add indicator of time remaining (#5000)
  [Video] add scrubber to the web player (#4943)
  Release 1.90 prep (#4988)
  Use moderatePost_wrapped for post embeds (#4981)
  Update Indonesian translation (#4875)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants