Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japanese translation #5374

Merged
merged 42 commits into from
Oct 7, 2024
Merged

Update Japanese translation #5374

merged 42 commits into from
Oct 7, 2024

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented Sep 17, 2024

Translate new messages

Hima-Zinn
Hima-Zinn reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review.

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@surfdude29 surfdude29 mentioned this pull request Sep 17, 2024
Merged
@tkusano
Copy link
Contributor Author

tkusano commented Sep 19, 2024

  • Due to the addition of font setting function, the translation of "Apperance Settgins" has been changed from "背景の設定" から "外観の設定".
  • Font settings dialog will appear when new version is loaded like below.

image

Hima-Zinn
Hima-Zinn reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plese check!

src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
src/locale/locales/ja/messages.po Outdated Show resolved Hide resolved
@tkusano
Copy link
Contributor Author

tkusano commented Sep 27, 2024

  • check email address (valid TLD, common domain misspellings), labeling required by region 64727e3
  • error correction 9679949
  • PDS self-hosting, starter pack, image cropping 277e586
  • Advanced search filter (language) 8da1072
  • Removed TenMillion related messages, etc. 7e3a458

@tkusano
Copy link
Contributor Author

tkusano commented Sep 28, 2024

  • Translated "pinned post" as "投稿を固定" (follow 4b5d6e6)
  • "pinned feed" is still translated as "フィードをピン留め", but should I change it to "フィードを固定"?

@dolciss
Copy link
Contributor

dolciss commented Sep 28, 2024 •
edited
Loading

  • "pinned feed" is still translated as "フィードをピン留め", but should I change it to "フィードを固定"?

still translated +1

"固定"は1つ、"ピン留め"は複数可能なイメージがあります
（LINEのトークルーム、Windowsのスタートメニュー、Discordの発言等）

@Hima-Zinn
Copy link
Contributor

どちらでも良いですが、個人的にはピン留めが好きです。
文字数とか考慮するなら固定でも。

@tkusano
Copy link
Contributor Author

tkusano commented Sep 29, 2024

文字数や、他で使われていること、日本語であることから「固定」がいいかなあと思います。

既存の「ピン留め」についてはとりあえずそのままにしておきます。

@tkusano
Copy link
Contributor Author

tkusano commented Oct 3, 2024

Update the translation for the message that appears when email verification is successful. 3569873

gaearon and others added 16 commits October 4, 2024 09:50
@gaearon @tkusano
Refactor video uploads (bluesky-social#5570)
f74f9bc 
* Remove unused video field

* Stop exposing video dispatch

* Move cancellation out of the reducer

* Make useUploadStatusQuery controlled by jobId

* Rename SetStatus to SetProcessing

This action only has one callsite and it's always passing "processing".

* Move jobId into video reducer state

* Make cancellation scoped

* Inline useCompressVideoMutation

* Move processVideo down the file

* Extract getErrorMessage

* useServiceAuthToken -> getServiceAuthToken

* useVideoAgent -> createVideoAgent

* useVideoUploadLimits -> getVideoUploadLimits

* useUploadVideoMutation -> uploadVideo

* Use async/await in processVideo

* Inline onVideoCompressed into processVideo

* Use async/await for uploadVideo

* Factor out error messages

* Guard dispatch with signal

This lets us remove the scattered signal checks around dispatch.

* Move job polling out of RQ

* Handle poll failures

* Remove unnecessary guards

* Slightly more accurate condition

* Move initVideoUri handling out of the hook

* Remove dead argument

It wasn't being used before either.

* Remove unused detailed status

This isn't being used because we're only respecting that state variable when isProcessing=true, but isProcessing is always false during video upload.

If we want to re-add this later, it should really just be derived from the reducer state.

* Harden the video reducer

* Tie all spawned work to a signal

* Preserve asset/media for nicer error state

* Rename actions to match states

* Inline useUploadVideo

This abstraction is getting in the way of some future work.

* Move MIME check to the only place that handles it
@gaearon @tkusano
Manage video reducer from composer reducer (bluesky-social#5573)
59589e3 
* Move video state into composer state

* Represent video as embed

This is slightly broken. In particular, we can't remove video yet because there's no action that results in video embed being removed.

* Properly represent video as embed

This aligns the video state lifetime with the embed lifetime. Video can now be properly added and removed.

* Disable Add Video when we have images

* Ignore empty image pick
@gaearon @tkusano
Rename some files and variables (bluesky-social#5587)
475708e 
* Move composer reducers together

* videoUploadState -> videoState

* Inline videoDispatch
@mozzius @tkusano
🪵📌 (bluesky-social#5594)
3ab5190
@mozzius @tkusano
[🐴] Reduce amount that message sent date is shown (bluesky-social#4228)
af8e342
@estrattonbailey @tkusano
Fix profile header buttons (bluesky-social#5558)
c00c5fa 
* Fix profile header buttons

* Adjust labeler buttons too

* Fix load state jumps

* Small tweak for web

* Remove log
@tkusano
Update
b073c04
@tkusano
Revert "Update"
e84c860 
This reverts commit b073c04.
@tkusano
Revert "Fix profile header buttons (bluesky-social#5558)"
e928cd1 
This reverts commit c00c5fa.
@tkusano
Revert "[🐴] Reduce amount that message sent date is shown (bluesky-so…
a36b781 
…cial#4228)"

This reverts commit af8e342.
@tkusano
Revert "🪵📌 (bluesky-social#5594)"
aff2332 
This reverts commit 3ab5190.
@tkusano
Revert "Rename some files and variables (bluesky-social#5587)"
30b8011 
This reverts commit 475708e.
@tkusano
Revert "Manage video reducer from composer reducer (bluesky-social#5573…
6e58339 
…)"

This reverts commit 59589e3.
@tkusano
Revert "Refactor video uploads (bluesky-social#5570)"
d139c7d 
This reverts commit f74f9bc.
@tkusano
Merge branch 'main' into ja-translation-17
5b62539
@tkusano
Update translation
221e650
@tkusano
Copy link
Contributor Author

tkusano commented Oct 4, 2024

estrattonbailey
estrattonbailey approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@estrattonbailey estrattonbailey merged commit c365096 into bluesky-social:main Oct 7, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Oct 8, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into tiptap
61a85a5 
* origin/main: (267 commits)
  Nicer error message for disabled quotes (#5644)
  Update neue nux date (#5643)
  Make alt text scrollable on native (#5642)
  Move remaining composer state into reducer (#5623)
  Fetch link previews from RQ (#5608)
  Use composer state as source of truth for embeds/links on publish (#5606)
  Update Indonesian translation (#5316)
  [Video] Add dimension info to share intent pt.2 (#5640)
  [Video] Prevent screen from dimming while in full screen (#5637)
  [Video] Add dimension info to share intent (#5639)
  [Video] Revert safari hackfix (#5367)
  Swipeable to delete chat, custom swipeable (#5614)
  equal spacing on displayname/handle (#5636)
  Update Japanese translation (#5374)
  Update catalana messages.po (#5380)
  Update and inconsistency fixes to pt-br translation (#5436)
  Tweak #5522 (#5635)
  Update Korean localization (#5401)
  Update Chinese localization (#5433)
  Add Cantonese Localization (#5479)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hima-Zinn Hima-Zinn Hima-Zinn left review comments

@estrattonbailey estrattonbailey estrattonbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tkusano @dolciss @Hima-Zinn @estrattonbailey @gaearon @mozzius