Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipeable to delete chat, custom swipeable #5614

Merged
merged 15 commits into from
Oct 7, 2024
Merged

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Oct 4, 2024

Same as #5579, but using a custom swipeable that (imo) is a bit nicer as far as usability (perform action on release instead of swipe open and then tap). Acts similar to the iOS mail deletion.

Can rm other changes or leave them - if we want this.

RocketSim_Recording_iPhone_16_Pro_6.3_2024-10-04_16.27.03.mp4

Copy link

github-actions bot commented Oct 4, 2024

Old size New size Diff
7.92 MB 7.92 MB 333 B (0.00%)

@arcalinea arcalinea temporarily deployed to hailey/swipeable-chats - social-app PR #5614 October 5, 2024 21:43 — with Render Destroyed
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although not tested on android. Idk if the mark read thing should have different behaviour if already read? current behaviour is fine though

I would maybe like some nicer icons but we can hit that in a follow-up

src/lib/custom-animations/GestureActionView.tsx Outdated Show resolved Hide resolved
@arcalinea arcalinea temporarily deployed to hailey/swipeable-chats - social-app PR #5614 October 7, 2024 18:10 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/swipeable-chats - social-app PR #5614 October 7, 2024 18:11 — with Render Destroyed
@haileyok haileyok merged commit 58b1d93 into main Oct 7, 2024
5 of 6 checks passed
@haileyok haileyok deleted the hailey/swipeable-chats branch October 7, 2024 18:15
estrattonbailey added a commit that referenced this pull request Oct 8, 2024
* origin/main: (267 commits)
  Nicer error message for disabled quotes (#5644)
  Update neue nux date (#5643)
  Make alt text scrollable on native (#5642)
  Move remaining composer state into reducer (#5623)
  Fetch link previews from RQ (#5608)
  Use composer state as source of truth for embeds/links on publish (#5606)
  Update Indonesian translation (#5316)
  [Video] Add dimension info to share intent pt.2 (#5640)
  [Video] Prevent screen from dimming while in full screen (#5637)
  [Video] Add dimension info to share intent (#5639)
  [Video] Revert safari hackfix (#5367)
  Swipeable to delete chat, custom swipeable (#5614)
  equal spacing on displayname/handle (#5636)
  Update Japanese translation (#5374)
  Update catalana messages.po (#5380)
  Update and inconsistency fixes to pt-br translation (#5436)
  Tweak #5522 (#5635)
  Update Korean localization (#5401)
  Update Chinese localization (#5433)
  Add Cantonese Localization (#5479)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants