Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce post reason icon size & offset #5522

Merged

Conversation

futurGH
Copy link
Contributor

@futurGH futurGH commented Sep 27, 2024

Makes the pin icon less aggressive, repost icon adjusted to match. Also edited the pin icon SVG because it visually appeared to have more space on the right side than on the left, causing right margin to be 1px off from the repost icon

Before After
image image

@estrattonbailey estrattonbailey changed the base branch from main to eric/feed-reason October 7, 2024 16:03
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These icons are all exported on the same artboard size, 24x24. I verified that this one is correct, any adjustments should be made in CSS only.

Looks great though, gonna merge into a base to tweak this and get this included. Thanks!

@estrattonbailey estrattonbailey merged commit 6e72fbb into bluesky-social:eric/feed-reason Oct 7, 2024
6 checks passed
@estrattonbailey estrattonbailey mentioned this pull request Oct 7, 2024
estrattonbailey added a commit that referenced this pull request Oct 7, 2024
* Reduce post reason icon size & offset (#5522)

* Make x margin within pin icon the same

* Reduce post reason icon size and offset

* Use existing pin

---------

Co-authored-by: futur <me@futuristick.ca>
@futurGH
Copy link
Contributor Author

futurGH commented Oct 7, 2024

Looks like the rounding when I optimized the SVG made the change barely perceptible anyways :P thanks!

@futurGH futurGH deleted the feed-reason branch October 7, 2024 18:44
estrattonbailey added a commit that referenced this pull request Oct 8, 2024
* origin/main: (267 commits)
  Nicer error message for disabled quotes (#5644)
  Update neue nux date (#5643)
  Make alt text scrollable on native (#5642)
  Move remaining composer state into reducer (#5623)
  Fetch link previews from RQ (#5608)
  Use composer state as source of truth for embeds/links on publish (#5606)
  Update Indonesian translation (#5316)
  [Video] Add dimension info to share intent pt.2 (#5640)
  [Video] Prevent screen from dimming while in full screen (#5637)
  [Video] Add dimension info to share intent (#5639)
  [Video] Revert safari hackfix (#5367)
  Swipeable to delete chat, custom swipeable (#5614)
  equal spacing on displayname/handle (#5636)
  Update Japanese translation (#5374)
  Update catalana messages.po (#5380)
  Update and inconsistency fixes to pt-br translation (#5436)
  Tweak #5522 (#5635)
  Update Korean localization (#5401)
  Update Chinese localization (#5433)
  Add Cantonese Localization (#5479)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants