Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neue] Post avi, PostMeta cleanup #5450

Merged
merged 18 commits into from
Sep 25, 2024
Merged

[Neue] Post avi, PostMeta cleanup #5450

merged 18 commits into from
Sep 25, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Sep 22, 2024

This PR shrinks the size of avatars in all post components to 42 from 52 (matches new ProfileCard). It also refactors PostMeta in situ to use our new text handling, and introduces WebOnlyInlineLinkText as a replacement for TextLinkOnWebOnly.

Closes #5346 and closes #5322

Copy link

github-actions bot commented Sep 22, 2024

Old size New size Diff
10.37 MB 10.37 MB 44 B (0.00%)

* origin/main:
  [Neue] Handle emoji within custom font (#5449)
  Use pressable for video controls (#5452)
  Resolve source files for fonts, remove hack (#5454)
  changed white (gray_0) text to offwhite (gray_25) (#5453)
  Let Expo/Webpack handle CSS assets (#3942)
@arcalinea arcalinea temporarily deployed to neue/post-avi - social-app PR #5450 September 23, 2024 18:16 — with Render Destroyed
@surfdude29
Copy link
Contributor

Along with the refactor in PostMeta, would it be possible to squeeze in the small fix in #5322 / #5346? 🙏

@estrattonbailey estrattonbailey changed the title Neue/post avi [Neue] Post avi, PostMeta cleanup Sep 24, 2024
@estrattonbailey
Copy link
Member Author

Thanks @surfdude29 will have a look!

* origin/main:
  Remove image resizer (#5464)
  Remove `react-native-fs` (#5463)
  Revamp image editor (#5462)
  Revamp edit image alt text dialog (#5461)
  MobX removal take 2 (#5381)
  Edit self hosting copy (#5469)
  Automatically optimise SVG assets (#5467)
  [Share Extension] Update to support video (#5385)
  Revert change in FAB animation (#5465)
  Improvements to NSE (#4992)
  Don't use flex on inputs (#5458)
  Fix web splash (#5456)
  invert the fab animation, play a haptic (#4309)
  add sideborders to <ProfileHeaderLoading> (#4995)
  [Video] Flush low quality segments once focused (#5430)
@arcalinea arcalinea temporarily deployed to neue/post-avi - social-app PR #5450 September 24, 2024 18:30 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to neue/post-avi - social-app PR #5450 September 24, 2024 20:34 — with Render Destroyed
@surfdude29
Copy link
Contributor

I just tried the preview branch and tested with Japanese and Korean, thanks for fixing the timestamp text wrapping! :)

@estrattonbailey estrattonbailey merged commit b38d469 into main Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants