Skip to content

[PW_SID:1081189] [v5] Bluetooth: hci_event: Fix OOB read and infinite loop in hci_le_create_big_complete_evt#82

Closed
BluezTestBot wants to merge 1 commit intoworkflowfrom
1081189
Closed

[PW_SID:1081189] [v5] Bluetooth: hci_event: Fix OOB read and infinite loop in hci_le_create_big_complete_evt#82
BluezTestBot wants to merge 1 commit intoworkflowfrom
1081189

Conversation

@BluezTestBot
Copy link
Copy Markdown

@BluezTestBot BluezTestBot commented Apr 14, 2026

From: Luiz Augusto von Dentz luiz.von.dentz@intel.com

hci_le_create_big_complete_evt() iterates over BT_BOUND connections for
a BIG handle using a while loop, accessing ev->bis_handle[i++] on each
iteration. However, there is no check that i stays within ev->num_bis
before the array access.

When a controller sends a LE_Create_BIG_Complete event with fewer
bis_handle entries than there are BT_BOUND connections for that BIG,
or with num_bis=0, the loop reads beyond the valid bis_handle[] flex
array into adjacent heap memory. Since the out-of-bounds values
typically exceed HCI_CONN_HANDLE_MAX (0x0EFF), hci_conn_set_handle()
rejects them and the connection remains in BT_BOUND state. The same
connection is then found again by hci_conn_hash_lookup_big_state(),
creating an infinite loop with hci_dev_lock held.

Fix this by terminating the BIG if in case not all BIS could be setup
properly.

Fixes: a0bfde1 ("Bluetooth: ISO: Add support for connecting multiple BISes")
Cc: stable@vger.kernel.org
Signed-off-by: ZhiTao Ou hkbinbinbin@gmail.com
Signed-off-by: Luiz Augusto von Dentz luiz.von.dentz@intel.com

net/bluetooth/hci_event.c | 29 ++++++++++++++++++++++++++---
1 file changed, 26 insertions(+), 3 deletions(-)

@Vudentz
Bluetooth: hci_event: Fix OOB read and infinite loop in hci_le_create…
ba32424 
…_big_complete_evt

hci_le_create_big_complete_evt() iterates over BT_BOUND connections for
a BIG handle using a while loop, accessing ev->bis_handle[i++] on each
iteration.  However, there is no check that i stays within ev->num_bis
before the array access.

When a controller sends a LE_Create_BIG_Complete event with fewer
bis_handle entries than there are BT_BOUND connections for that BIG,
or with num_bis=0, the loop reads beyond the valid bis_handle[] flex
array into adjacent heap memory.  Since the out-of-bounds values
typically exceed HCI_CONN_HANDLE_MAX (0x0EFF), hci_conn_set_handle()
rejects them and the connection remains in BT_BOUND state.  The same
connection is then found again by hci_conn_hash_lookup_big_state(),
creating an infinite loop with hci_dev_lock held.

Fix this by terminating the BIG if in case not all BIS could be setup
properly.

Fixes: a0bfde1 ("Bluetooth: ISO: Add support for connecting multiple BISes")
Cc: stable@vger.kernel.org
Signed-off-by: ZhiTao Ou <hkbinbinbin@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.65 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

GitLint
Desc: Run gitlint
Duration: 0.27 seconds
Result: FAIL
Output:

[v5] Bluetooth: hci_event: Fix OOB read and infinite loop in hci_le_create_big_complete_evt

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (91>80): "[v5] Bluetooth: hci_event: Fix OOB read and infinite loop in hci_le_create_big_complete_evt"

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

SubjectPrefix
Desc: Check subject contains "Bluetooth" prefix
Duration: 0.09 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

BuildKernel
Desc: Build Kernel for Bluetooth
Duration: 27.35 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

CheckAllWarning
Desc: Run linux kernel with all warning enabled
Duration: 30.09 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

CheckSparse
Desc: Run sparse tool with linux kernel
Duration: 28.67 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

BuildKernel32
Desc: Build 32bit Kernel for Bluetooth
Duration: 26.72 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunnerSetup
Desc: Setup kernel and bluez for test-runner
Duration: 584.01 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_l2cap-tester
Desc: Run l2cap-tester with test-runner
Duration: 28.66 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_iso-tester
Desc: Run iso-tester with test-runner
Duration: 35.40 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_bnep-tester
Desc: Run bnep-tester with test-runner
Duration: 6.67 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_mgmt-tester
Desc: Run mgmt-tester with test-runner
Duration: 117.98 seconds
Result: FAIL
Output:

Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.111 seconds

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_rfcomm-tester
Desc: Run rfcomm-tester with test-runner
Duration: 9.72 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_sco-tester
Desc: Run sco-tester with test-runner
Duration: 14.66 seconds
Result: FAIL
Output:

WARNING: possible circular locking dependency detected
7.0.0-rc2-ge2297ca80d65 #1 Not tainted
------------------------------------------------------
kworker/u5:0/115 is trying to acquire lock:
ffff888001946240 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_connect_cfm+0x358/0x8d0

but task is already holding lock:
ffff8880025f6220 (&conn->lock){+.+.}-{3:3}, at: sco_connect_cfm+0x22d/0x8d0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&conn->lock){+.+.}-{3:3}:
       lock_acquire+0xf7/0x2c0
       _raw_spin_lock+0x2a/0x40
       sco_sock_connect+0x4d7/0x1280
       __sys_connect+0x1a3/0x260
       __x64_sys_connect+0x6e/0xb0
       do_syscall_64+0xa0/0x570
       entry_SYSCALL_64_after_hwframe+0x74/0x7c

-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
       check_prev_add+0xe9/0xc70
       __lock_acquire+0x1457/0x1df0
       lock_acquire+0xf7/0x2c0
       lock_sock_nested+0x36/0xd0
       sco_connect_cfm+0x358/0x8d0
       hci_sync_conn_complete_evt+0x3d3/0x8e0
       hci_event_packet+0x74f/0xb10
       hci_rx_work+0x398/0xd00
       process_scheduled_works+0xb16/0x1ac0
       worker_thread+0x4ff/0xba0
       kthread+0x368/0x490
       ret_from_fork+0x498/0x7e0
       ret_from_fork_asm+0x19/0x30

other info that might help us debug this:

...
BUG: sleeping function called from invalid context at net/core/sock.c:3782
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 115, name: kworker/u5:0
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
CPU: 0 UID: 0 PID: 115 Comm: kworker/u5:0 Not tainted 7.0.0-rc2-ge2297ca80d65 #1 PREEMPT(lazy) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014
Workqueue: hci0 hci_rx_work
Call Trace:
 <TASK>
 dump_stack_lvl+0x49/0x60
 __might_resched+0x2ea/0x500
 lock_sock_nested+0x47/0xd0
 ? sco_connect_cfm+0x358/0x8d0
 sco_connect_cfm+0x358/0x8d0
 ? hci_debugfs_create_conn+0x190/0x210
 ? __pfx_sco_connect_cfm+0x10/0x10
 hci_sync_conn_complete_evt+0x3d3/0x8e0
 hci_event_packet+0x74f/0xb10
 ? __pfx_hci_sync_conn_complete_evt+0x10/0x10
 ? __pfx_hci_event_packet+0x10/0x10
 ? mark_held_locks+0x49/0x80
 ? lockdep_hardirqs_on_prepare+0xd4/0x180
 ? _raw_spin_unlock_irqrestore+0x2c/0x50
 hci_rx_work+0x398/0xd00
 process_scheduled_works+0xb16/0x1ac0
 ? __pfx_process_scheduled_works+0x10/0x10
 ? lock_acquire+0xf7/0x2c0
 ? lock_is_held_type+0x9b/0x110
 ? __pfx_hci_rx_work+0x10/0x10
 worker_thread+0x4ff/0xba0
 ? __pfx_worker_thread+0x10/0x10
 kthread+0x368/0x490
 ? _raw_spin_unlock_irq+0x23/0x40
 ? __pfx_kthread+0x10/0x10
 ret_from_fork+0x498/0x7e0
 ? __pfx_ret_from_fork+0x10/0x10
 ? __switch_to+0x9e4/0xe50
 ? __switch_to_asm+0x32/0x60
 ? __pfx_kthread+0x10/0x10
...
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_ioctl-tester
Desc: Run ioctl-tester with test-runner
Duration: 10.62 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_mesh-tester
Desc: Run mesh-tester with test-runner
Duration: 12.19 seconds
Result: FAIL
Output:

Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.613 seconds
Mesh - Send cancel - 2                               Timed out    2.000 seconds

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_smp-tester
Desc: Run smp-tester with test-runner
Duration: 8.89 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_userchan-tester
Desc: Run userchan-tester with test-runner
Duration: 6.92 seconds
Result: PASS

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

TestRunner_6lowpan-tester
Desc: Run 6lowpan-tester with test-runner
Duration: 8.61 seconds
Result: FAIL
Output:

WARNING: possible circular locking dependency detected
7.0.0-rc2-ge2297ca80d65 #1 Not tainted
------------------------------------------------------
kworker/0:1/10 is trying to acquire lock:
ffff8880026e4940 ((wq_completion)hci0#2){+.+.}-{0:0}, at: touch_wq_lockdep_map+0x75/0x180

but task is already holding lock:
ffffffffa5a4d720 (rtnl_mutex){+.+.}-{4:4}, at: lowpan_unregister_netdev+0xd/0x30

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (rtnl_mutex){+.+.}-{4:4}:
       lock_acquire+0xf7/0x2c0
       __mutex_lock+0x16b/0x1fc0
       lowpan_register_netdev+0x11/0x30
       chan_ready_cb+0x836/0xd00
       l2cap_recv_frame+0x6a06/0x8920
       l2cap_recv_acldata+0x790/0xdf0
       hci_rx_work+0x500/0xd00
       process_scheduled_works+0xb16/0x1ac0
       worker_thread+0x4ff/0xba0
       kthread+0x368/0x490
       ret_from_fork+0x498/0x7e0
       ret_from_fork_asm+0x19/0x30

-> #3 (&chan->lock#3/1){+.+.}-{4:4}:
       lock_acquire+0xf7/0x2c0
       __mutex_lock+0x16b/0x1fc0
       l2cap_chan_connect+0x74e/0x1980
       lowpan_control_write+0x523/0x660
       full_proxy_write+0x10b/0x190
       vfs_write+0x1c0/0xf60
       ksys_write+0xf1/0x1d0
       do_syscall_64+0xa0/0x570
       entry_SYSCALL_64_after_hwframe+0x74/0x7c

-> #2 (&conn->lock){+.+.}-{4:4}:
...
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 1.44 seconds
Result: FAIL
Output:


fatal: previous rebase directory .git/rebase-apply still exists but mbox given.

@BluezTestBot BluezTestBot deleted the 1081189 branch April 14, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BluezTestBot @Vudentz