Skip to content

Conversation

@mtracz
Copy link
Member

@mtracz mtracz commented Apr 10, 2025

This pull request includes several changes aimed at updating environment configurations, improving Docker setup, and modifying the Vite configuration. The most important changes include updating environment variables in the .env.example file, modifying the docker-compose.yml file to use new host names, and updating the Vite configuration to enhance server setup.

Environment Configuration Updates:

  • Updated APP_URL and added new host name variables for Docker in the .env.example file. ([[1]](https://github.com/blumilksoftware/toby/pull/527/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cL5-R5), [[2]](https://github.com/blumilksoftware/toby/pull/527/files#diff-a3046da0d15a27e89f2afe639b25748a7ad4d9290af3e7b1b6c1a5533c8f0a8cL67-R71))

Docker Setup Improvements:

  • Modified docker-compose.yml to use new host names and added configurations for the Vite dev server and Mailpit service. ([[1]](https://github.com/blumilksoftware/toby/pull/527/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L11-R30), [[2]](https://github.com/blumilksoftware/toby/pull/527/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L32-R42), [[3]](https://github.com/blumilksoftware/toby/pull/527/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L82-R99), [[4]](https://github.com/blumilksoftware/toby/pull/527/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L98-R108), [[5]](https://github.com/blumilksoftware/toby/pull/527/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L113-R123))

Vite Configuration Enhancements:

  • Updated vite.config.js to use a fixed port and new origin, and removed the use of networkInterfaces for determining the host. ([[1]](https://github.com/blumilksoftware/toby/pull/527/files#diff-58e6f63d87181b1c6a8cb6e5f1691df04aa32854456efcd52ca71c8541375d26L4), [[2]](https://github.com/blumilksoftware/toby/pull/527/files#diff-58e6f63d87181b1c6a8cb6e5f1691df04aa32854456efcd52ca71c8541375d26L14-R17))

Supervisor Configuration Update:

  • Changed the user for the unitd command in supervisord.conf to host-user. ([environment/dev/app/supervisord.confL11-R11](https://github.com/blumilksoftware/toby/pull/527/files#diff-9d54e785b8647cea9638c551dad4b78fdeb24db0bc392d326aaa1c404291b391L11-R11))

This PR updates local environment to be compatible with new Blumilk environment:

From now we will be able to develop apps with Vite dev server via HTTPS and HTTP.
For more details check PR linked above.

Additionally:

  • fixed issue with storage dir permissions for unit server (previously unit was run as unit user and has no access to the project files).

@mtracz mtracz requested a review from a team as a code owner April 10, 2025 18:21
@mtracz mtracz requested a review from a team April 10, 2025 18:30
kamilpiech97
kamilpiech97 previously approved these changes Apr 11, 2025
@mtracz mtracz merged commit 1c9c7a3 into main Apr 16, 2025
2 checks passed
@mtracz mtracz deleted the new-blumilk-environment branch April 16, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants