Conversation
Module content is delivered via git clone in the bmm installer, not via npm packages. Remove publish.yaml workflow, npm publish step from manual-release.yaml, and mark package as private.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request removes NPM publishing capabilities from the project by eliminating the dedicated publish workflow, removing npm distribution steps from the manual release workflow, and marking the package as private in package.json. This prevents automated npm package publishing. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: Disables npm publishing for bmad-builder to prevent accidental registry releases.
🤖 Was this summary useful? React with 👍 or 👎 |
| echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY | ||
| echo "npx bmad-method@${{ steps.version.outputs.new_version }} install" >> $GITHUB_STEP_SUMMARY | ||
| echo "\`\`\`" >> $GITHUB_STEP_SUMMARY | ||
| echo "- **GitHub Release**: https://github.com/bmad-code-org/bmad-builder/releases/tag/v${{ steps.version.outputs.new_version }}" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
This step summary now links to bmad-builder releases, but the workflow still generates release metadata/links referencing BMAD-METHOD / "BMad Method", which may confuse users following the release output. Consider making the repo/product references consistent throughout the workflow (e.g., release name and the “Full Changelog” URL).
Severity: medium
Other Locations
.github/workflows/manual-release.yaml:127.github/workflows/manual-release.yaml:158
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| { | ||
| "$schema": "https://json.schemastore.org/package.json", | ||
| "name": "bmad-builder", | ||
| "private": true, |
There was a problem hiding this comment.
Setting "private": true will hard-fail any npm publish attempts, but it also means anything still relying on the npm registry as a version lookup will stop working. If there’s still an installer/status check querying npm for versions, it likely needs to be fully switched to git tags/GitHub releases.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 4: package.json is failing Prettier --check; run the project's formatter
to normalize formatting (e.g., run the npm script "format:fix" or execute
"prettier --write package.json"), review the resulting changes to package.json,
and commit the formatted file so the Prettier check passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: faab9f7a-19d4-45ba-b533-18c4ea506918
📒 Files selected for processing (3)
.github/workflows/manual-release.yaml.github/workflows/publish.yamlpackage.json
💤 Files with no reviewable changes (1)
- .github/workflows/publish.yaml
Summary
publish.yamlworkflow (tag-triggered npm auto-publish)manual-release.yaml"private": truetopackage.jsonto prevent accidental publishesModule content is delivered via git clone in the bmm installer, not npm packages. The npm publish was only being used as a version lookup service for the installer's status/update-check, which can be replaced with git tags.
Test plan
manual-release.yamlstill creates git tags and GitHub releasesnpm publishfails locally due to"private": trueSummary by CodeRabbit