Skip to content

refactor: consolidate plugin.json into marketplace.json#42

Merged
bmadcode merged 1 commit intomainfrom
consolidate-plugin-json
Mar 27, 2026
Merged

refactor: consolidate plugin.json into marketplace.json#42
bmadcode merged 1 commit intomainfrom
consolidate-plugin-json

Conversation

@bmadcode
Copy link
Copy Markdown
Contributor

@bmadcode bmadcode commented Mar 27, 2026

Summary

  • Merged all metadata from plugin.json (license, homepage, repository, keywords, author, description) into marketplace.json
  • Removed redundant plugin.json — the npx skills installer only reads marketplace.json for skill discovery

Test plan

  • Verify npx skills add bmad-code-org/bmad-builder still discovers and installs all 3 skills
  • Confirm marketplace listing displays correctly

Summary by CodeRabbit

  • Chores
    • Consolidated and updated plugin metadata, including author information, licensing details, and project links for improved transparency and discoverability.

Merge license, homepage, repository, keywords, and author from
plugin.json into marketplace.json and remove the redundant file.
The npx skills installer only reads marketplace.json for skill
discovery — plugin.json contributed no functional value.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

Walkthrough

The pull request updates Claude plugin configuration by enhancing .claude-plugin/marketplace.json with metadata fields (license, homepage, repository, keywords) and refining the plugin description and author information, while removing the now-redundant .claude-plugin/plugin.json file.

Changes

Cohort / File(s) Summary
Plugin Configuration
.claude-plugin/marketplace.json
Added package metadata fields (license, homepage, repository, keywords) and plugin-level author object. Updated plugin description to clarify conversation-to-skill-structure mapping.
Plugin Configuration
.claude-plugin/plugin.json
Deleted file containing duplicate plugin metadata declarations (name, version, description, author, license, homepage, repository, keywords).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A flutter of whiskers, a hop of delight,
Metadata polished, now shining so bright!
One file retires, its duty now done,
Marketplace blooms with each added one! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: consolidating plugin.json metadata into marketplace.json and removing the redundant file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch consolidate-plugin-json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.claude-plugin/marketplace.json (1)

16-18: Consider avoiding duplicated maintainer metadata (owner vs plugins[0].author).

With both present, they can drift over time. If schema allows, prefer a single source of truth and derive/render the other at publish time.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.claude-plugin/marketplace.json around lines 16 - 18, The manifest currently
duplicates maintainer metadata between owner and plugins[0].author; pick one
canonical field (either owner or plugins[0].author) and remove the other to
avoid drift, then update any publish/build code that reads the manifest so it
derives the removed field at publish time (e.g., when publishing, if owner is
canonical populate plugins[0].author from owner, or vice versa); specifically
edit the JSON to keep a single maintainer source and adjust the publish pipeline
logic that references owner and plugins[0].author so it consistently reads the
canonical field and synthesizes the secondary one when generating packaged
metadata.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.claude-plugin/marketplace.json:
- Around line 16-18: The manifest currently duplicates maintainer metadata
between owner and plugins[0].author; pick one canonical field (either owner or
plugins[0].author) and remove the other to avoid drift, then update any
publish/build code that reads the manifest so it derives the removed field at
publish time (e.g., when publishing, if owner is canonical populate
plugins[0].author from owner, or vice versa); specifically edit the JSON to keep
a single maintainer source and adjust the publish pipeline logic that references
owner and plugins[0].author so it consistently reads the canonical field and
synthesizes the secondary one when generating packaged metadata.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 957185fe-2952-4146-b07f-d65918b76947

📥 Commits

Reviewing files that changed from the base of the PR and between 916cd52 and 7c4d625.

📒 Files selected for processing (2)
  • .claude-plugin/marketplace.json
  • .claude-plugin/plugin.json
💤 Files with no reviewable changes (1)
  • .claude-plugin/plugin.json

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Mar 27, 2026

🤖 Augment PR Summary

Summary: Consolidates previously duplicated plugin metadata into .claude-plugin/marketplace.json and updates the listing description/author details.
Rationale: Removes .claude-plugin/plugin.json as redundant so marketplace-based skill discovery has a single source of truth.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

"owner": {
"name": "Brian (BMad) Madison"
},
"license": "MIT",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.claude-plugin/marketplace.json is often parsed/validated against a fairly tight marketplace schema; adding top-level keys like license/homepage/repository/keywords may cause validation or discovery tooling to reject the manifest. Can you confirm the target consumer for this file accepts these top-level fields?

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@@ -1,12 +0,0 @@
{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With .claude-plugin/plugin.json removed, please double-check that the remaining marketplace.json configuration is sufficient for all intended consumers (e.g., Claude Code plugin loading/validation vs npx skills discovery). Some plugin systems assume plugin.json exists unless the marketplace entry is explicitly configured not to rely on it.

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@bmadcode bmadcode merged commit dcffcee into main Mar 27, 2026
6 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 8, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant