Fix for static student gradebook alignment#287
Fix for static student gradebook alignment#287gjb2048 wants to merge 1 commit intobmbrands:masterfrom
Conversation
|
Is this required for BS3? from the forum post it looks like a theme Elegance issue. |
|
It is as Elegance is Bs3 based and code is identical. Sent from my iPod in deep space... On 24 Jun 2014, at 09:56, Bas Brands notifications@github.com wrote:
|
|
Tis a Bootstrap issue too :) |
|
Hmm I can't see any misalignment on the grade report. Perhaps browser specific? |
|
Ah ha! Have you turned this setting on: https://moodle.org/mod/forum/discuss.php?d=261626#p1133556 Bas? |
|
Oh missed this reply. Yes I did have the fixed student column and could not notice any issues. Could you check again too? |
|
Hi Bas, Just tested on current master and seems fine:
G |
|
P.S. On Chrome. Not tested elsewhere! Lunch, so will test on IE after. |
|
Long lunch!....
|
|
|
|
So we are all good? Thanks a lot for testing!! |
|
Indeed! Until its broken again!... gjb2048/moodle-theme_essential#175 In the gradebook, nobody can hear you scream! ;) |
2 participants
Fix for https://moodle.org/mod/forum/discuss.php?d=261626 - instead of reducing #user-grades down to 2px which affects table regardless of the core setting 'grade_report_fixedstudents' to bring into alignment, this is now set at 0px such that the scroll bar at the top is completely adjacent as the bottom one is. Then reducing the specific '.left-scroller' (the padding on the contained table has no effect) down by 2px brings everything into alignment when 'grade_report_fixedstudents' is set.