KG - Fix Survey Question Validation When Dependent on Option Selection#299
Merged
Stuart-Johnson merged 8 commits intomasterfrom May 30, 2017
Merged
KG - Fix Survey Question Validation When Dependent on Option Selection#299Stuart-Johnson merged 8 commits intomasterfrom
Stuart-Johnson merged 8 commits intomasterfrom
Conversation
added 7 commits
May 26, 2017 14:47
jwiel86
approved these changes
May 30, 2017
Stuart-Johnson
approved these changes
May 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivotal Story:
https://www.pivotaltracker.com/story/show/146091507
Feature:
When surveys had questions which were both required and dependent on another option, if that question wasn't filled out, despite the depender option not being selected, it would fail validations. Instead, if the depender option isn't selected, it should ignore validations on the question.
Fix:
Because the presence validation is run pre-save, I didn't have access to the other question responses that I needed to check whether the option was selected. Instead, I had to use an after_save callback to apply errors if the use-case was met, then check for those errors in the controller.