fix(patch): on non-UTF8 filename, error rather than panic #65
Open
weihanglo wants to merge 8 commits intobmwill:masterfrom
Open
fix(patch): on non-UTF8 filename, error rather than panic #65weihanglo wants to merge 8 commits intobmwill:masterfrom
weihanglo wants to merge 8 commits intobmwill:masterfrom
Conversation
Octal escape \377 decodes to 0xFF, which is not valid UTF-8. When parsing into `Patch<'_, str>`, `convert_cow_to_str` panics via `unwrap()` instead of returning a parse error. See bmwill#59 (comment)
This is unfortunate we doesn't support non-UTF8 filename with `Patch<'_, str>` type (pre-existing btw).
`Text::owned_from_bytes` conversion is needed when escape sequences are decoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is unfortunate we doesn't support non-UTF8 filename with
Patch<'_, str>type (pre-existing btw).This is a spin-off of refactors in #59, and addresses