Merged
Conversation
cryptom-dev
commented
Mar 12, 2019
| return nil | ||
| } | ||
|
|
||
| //!!!!!!!!!!!!!!!!!!!! DELETE BEFORE MERGE |
Contributor
Author
There was a problem hiding this comment.
my fault forgot delete :(
Contributor
|
I am pretty much ok with the change. We need to upgrade QA first and went through a breathe block to ensure this would not any problem, as we clean up potentially many orders in the memory. |
Contributor
Author
deployed to QA, new drop logic will take effect after height 195000 |
rickyyangz
previously approved these changes
Mar 20, 2019
# Conflicts: # Gopkg.lock # Gopkg.toml # common/upgrade/upgrade.go # plugins/dex/matcheng/engine.go
rickyyangz
approved these changes
Mar 20, 2019
darren-liu
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged after
#502
Description
Fully fill order might not be correctly removed in orderbook when two continuous orders fully filled.
Caused by slice deletion nest.
Rationale
tell us why we need these changes...
Example
N/A
Changes
fix nest deletion bug
make expire logic more defensive
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...