Skip to content

Conversation

@NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Jul 5, 2023

Description

clear up all vote addrs when the height of new hardfork reached

Rationale

a part of solving rogue key attack
refer to bnb-chain/bnc-cosmos-sdk#353

Example

Changes

  1. clear up all existed vote address when the height of hardfork reached
  2. upgrade go version to 1.19 and upgrade go lint to 1.53.3
  3. modify Dockerfile, add more package needed when compile and run

PS: change github.com/tendermint/crypto to new created github.com/bnb-chain/tendermint-crypto
github.com/bnb-chain/tendermint-crypto is based on golang.org/x/crypto@v0.5.0 which others mod needed

@pythonberg1997
Copy link
Contributor

Please check the CI issues

Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issue

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.08%. Comparing base (a2be24e) to head (abc676b).
⚠️ Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
app/app.go 0.00% 4 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #964      +/-   ##
===========================================
- Coverage    49.10%   49.08%   -0.02%     
===========================================
  Files          127      127              
  Lines        12698    12703       +5     
===========================================
  Hits          6235     6235              
- Misses        6040     6044       +4     
- Partials       423      424       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buddh0 buddh0 merged commit fd1da2a into bnb-chain:develop Jul 6, 2023
@NathanBSC NathanBSC deleted the clear_side_vote_addrs branch July 7, 2023 03:49
forcodedancing pushed a commit to forcodedancing/node that referenced this pull request Jul 7, 2023
forcodedancing pushed a commit to forcodedancing/node that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants