[TEMPLATE] add FastAPI-fastkit dependency at all templates #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbong
added
template
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds fastapi-fastkit as a dependency across all FastAPI project templates and raises the minimum supported Python version in each template.
- Add fastapi-fastkit (target version 1.1.5) to requirements and pyproject dependencies across templates
- Bump requires-python to >=3.12 in all pyproject.toml-tpl files
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| src/fastapi_fastkit/fastapi_project_template/fastapi-single-module/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-single-module/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-psql-orm/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-psql-orm/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-mcp/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-mcp/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-empty/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-empty/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-dockerized/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-dockerized/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-default/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-default/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-custom-response/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-custom-response/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
| src/fastapi_fastkit/fastapi_project_template/fastapi-async-crud/requirements.txt-tpl | Add fastapi-fastkit pinned in requirements |
| src/fastapi_fastkit/fastapi_project_template/fastapi-async-crud/pyproject.toml-tpl | Add fastapi-fastkit and raise requires-python to >=3.12 |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| pydantic-settings==2.7.1 | ||
| pytest==8.3.4 | ||
| httpx==0.28.1 | ||
| FastAPI-fastkit==1.1.5 |
There was a problem hiding this comment.
[nitpick] Normalize the package name to lowercase to match canonical PEP 503 normalization and to be consistent with pyproject.toml in this template: use fastapi-fastkit==1.1.5.
Suggested change
| FastAPI-fastkit==1.1.5 | |
| fastapi-fastkit==1.1.5 |
| uvloop==0.21.0 | ||
| watchfiles==1.0.4 | ||
| websockets==15.0 | ||
| FastAPI-fastkit==1.1.5 |
There was a problem hiding this comment.
[nitpick] Use lowercase for the package name to align with normalized package naming and match pyproject.toml: fastapi-fastkit==1.1.5.
Suggested change
| FastAPI-fastkit==1.1.5 | |
| fastapi-fastkit==1.1.5 |
| uvloop==0.21.0 | ||
| watchfiles==1.0.4 | ||
| websockets==15.0 | ||
| FastAPI-fastkit==1.1.5 |
There was a problem hiding this comment.
[nitpick] Package names should be lowercase; update to fastapi-fastkit==1.1.5 for consistency and adherence to packaging conventions.
Suggested change
| FastAPI-fastkit==1.1.5 | |
| fastapi-fastkit==1.1.5 |
| isort==6.0.0 | ||
| mypy==1.15.0 | ||
| setuptools==80.9.0 | ||
| FastAPI-fastkit==1.1.5 |
There was a problem hiding this comment.
[nitpick] Switch to lowercase package name for consistency: fastapi-fastkit==1.1.5.
Suggested change
| FastAPI-fastkit==1.1.5 | |
| fastapi-fastkit==1.1.5 |
| uvloop==0.21.0 | ||
| watchfiles==1.0.4 | ||
| websockets==15.0 | ||
| FastAPI-fastkit==1.1.5 |
There was a problem hiding this comment.
[nitpick] Normalize package casing to lowercase to match pyproject and packaging norms: fastapi-fastkit==1.1.5.
Suggested change
| FastAPI-fastkit==1.1.5 | |
| fastapi-fastkit==1.1.5 |
src/fastapi_fastkit/fastapi_project_template/fastapi-mcp/pyproject.toml-tpl
Show resolved
Hide resolved
src/fastapi_fastkit/fastapi_project_template/fastapi-empty/pyproject.toml-tpl
Show resolved
Hide resolved
src/fastapi_fastkit/fastapi_project_template/fastapi-dockerized/pyproject.toml-tpl
Show resolved
Hide resolved
src/fastapi_fastkit/fastapi_project_template/fastapi-default/pyproject.toml-tpl
Show resolved
Hide resolved
src/fastapi_fastkit/fastapi_project_template/fastapi-custom-response/pyproject.toml-tpl
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting Merging
Description
add FastAPI-fastkit dependency at all templates
Type of Change
Test Environment
local, M1 Mac
Major Changes
FastAPI-fastkitdependency at all templates (FastAPI-fastkit target version => 1.1.5)Screenshots (optional)
N/A
Etc
close #22