Conversation
Owner
Author
|
@codex review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the Spanish (es) documentation locale for FastAPI-fastkit and updates translation status references across locales to reflect Spanish coverage, including switching the Spanish changelog page to a wrapper that reuses the canonical root CHANGELOG.md.
Changes:
- Add/complete Spanish documentation pages under
docs/es/(user guide, tutorials, contributing, reference) and adddocs/es/changelog.mdas a wrapper include. - Update translation status tables in
en,ja, andkodocs to mark Spanish as complete (26 / 26) and refresh the snapshot date. - Add/refresh Spanish “translation status” and related policy/reference pages to align with the current i18n workflow.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/ko/reference/translation-status.md | Marks Spanish as complete and updates the snapshot note/date. |
| docs/ja/reference/translation-status.md | Marks Spanish as complete and updates the snapshot note/date. |
| docs/en/reference/translation-status.md | Marks Spanish as complete and updates the snapshot note/date. |
| docs/es/index.md | Adds Spanish landing page content and navigation entry points. |
| docs/es/changelog.md | Adds Spanish changelog wrapper that includes canonical CHANGELOG.md. |
| docs/es/reference/translation-status.md | Adds Spanish translation-status source-of-truth and workflow explanation. |
| docs/es/user-guide/installation.md | Adds Spanish installation guide. |
| docs/es/user-guide/quick-start.md | Adds Spanish quick-start guide. |
| docs/es/user-guide/choosing-a-starter.md | Adds Spanish “choosing a starter” guidance. |
| docs/es/user-guide/creating-projects.md | Adds Spanish project creation guide. |
| docs/es/user-guide/adding-routes.md | Adds Spanish “adding routes” guide. |
| docs/es/user-guide/using-templates.md | Adds Spanish “using templates” guide. |
| docs/es/tutorial/getting-started.md | Adds Spanish getting-started tutorial. |
| docs/es/tutorial/basic-api-server.md | Adds Spanish basic API server tutorial. |
| docs/es/tutorial/async-crud-api.md | Adds Spanish async CRUD tutorial. |
| docs/es/tutorial/domain-starter.md | Adds Spanish domain-starter tutorial. |
| docs/es/reference/preset-feature-matrix.md | Adds Spanish preset/feature matrix reference. |
| docs/es/reference/template-quality-assurance.md | Adds Spanish template QA reference. |
| docs/es/reference/faq.md | Adds Spanish FAQ reference. |
| docs/es/contributing/translation-guide.md | Adds Spanish translation guide aligned with current workflow/policy. |
| docs/es/contributing/template-creation-guide.md | Adds Spanish template creation guide. |
| docs/es/contributing/code-guidelines.md | Adds Spanish code guidelines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
39
to
45
| | 🇨🇳 Chinese (`zh`) | 🔴 Skeleton | 0 / 26 | Build target only. Every page falls back to English. | | ||
| | 🇪🇸 Spanish (`es`) | 🔴 Skeleton | 0 / 26 | Build target only. Every page falls back to English. | | ||
| | 🇪🇸 Spanish (`es`) | ✅ Complete | 26 / 26 | All locale pages are present. Phase 1: top-level + core user-guide; Phase 2: remaining user-guide + all tutorials; Phase 3: contributing + reference. `docs/es/changelog.md` intentionally reuses the canonical English `CHANGELOG.md`. | | ||
| | 🇫🇷 French (`fr`) | 🔴 Skeleton | 0 / 26 | Build target only. Every page falls back to English. | | ||
| | 🇩🇪 German (`de`) | 🔴 Skeleton | 0 / 26 | Build target only. Every page falls back to English. | | ||
|
|
||
| *Snapshot verified 2026-05-10; ja row recounted for the current branch after Phase 3 (contributing + reference) landed. Japanese now has all locale pages present, while `docs/ja/changelog.md` intentionally points to the canonical English changelog.* These counts are maintained by hand; | ||
| *Snapshot verified 2026-05-11; es row recounted for the current branch after Phase 3 (contributing + reference) landed. Spanish now has all locale pages present, while `docs/es/changelog.md` intentionally points to the canonical English changelog.* These counts are maintained by hand; | ||
| to recount the current state from the repo root, run: |
Copilot stopped work on behalf of
bnbong due to an error
May 11, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting Merging
Description
Part of #59
Refs #60
Closes #64
This PR completes the Spanish documentation localization rollout for FastAPI-fastkit and aligns the related Spanish translation policy/docs with the current localization workflow.
The main goal of this PR is to provide a complete Spanish locale under
docs/es/, improve readability and terminology consistency across translated pages, and clarify that the repository-rootCHANGELOG.mdremains the canonical English release history.Type of Change
Test Environment
uvuv run mkdocs buildDocumentation built successfullyMajor Changes
Completed the Spanish docs locale under
docs/es/26 / 26markdown pages presentImproved Spanish readability and terminology consistency
Updated translation policy and status docs
docs/en/) as the source of truthClarified changelog handling for localized docs
CHANGELOG.mdas the canonical English release historydocs/es/changelog.mdto act as a Spanish entry point / wrapper for the canonical English changelog instead of maintaining a separate translated release historyRefined Spanish docs navigation and cross-page consistency
Screenshots (optional)
N/A
Etc