Add a way to add setters/getters in js_class! #3911
Merged
raskad merged 6 commits intoboa-dev:mainfrom Jul 21, 2024
Merged
Conversation
Contributor
Author
|
Converting to draft as I've come up with a better interface for getter/setter. Basically: prop name_of_prop as "nameOfProp" {
fn getter(...) {}
fn setter(...) {}
}with getter and setter optional. That way we don't need 3 sections for properties and it's a bit simpler. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3911 +/- ##
==========================================
+ Coverage 47.24% 51.59% +4.35%
==========================================
Files 476 468 -8
Lines 46892 44839 -2053
==========================================
+ Hits 22154 23136 +982
+ Misses 24738 21703 -3035 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Okay this does use the new API now. |
jedel1043
approved these changes
Jul 17, 2024
Member
jedel1043
left a comment
There was a problem hiding this comment.
Good work! Looks perfect to me.
Member
|
Thought: the syntax is getting a bit too DSL-like, so I'll probably see if I can start working on that proc macro. |
raskad
approved these changes
Jul 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And update documentation for more explanation around the macro.