Skip to content

Add a js_error! macro to create opaque errors#3920

Merged
nekevss merged 4 commits intoboa-dev:mainfrom
hansl:js_error
Jul 19, 2024
Merged

Add a js_error! macro to create opaque errors#3920
nekevss merged 4 commits intoboa-dev:mainfrom
hansl:js_error

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Jul 16, 2024

And as a bonus since I needed it, simplify comparison of strings and add PartialEq<&str> for JsString.

And as a bonus since I needed it, simplify comparison of strings
and add PartialEq<&str> for JsString.
@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.52%. Comparing base (6ddc2b4) to head (e74ca1c).
Report is 211 commits behind head on main.

Files Patch % Lines
core/string/src/lib.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
+ Coverage   47.24%   51.52%   +4.28%     
==========================================
  Files         476      467       -9     
  Lines       46892    44803    -2089     
==========================================
+ Hits        22154    23085     +931     
+ Misses      24738    21718    -3020     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansl hansl requested a review from jedel1043 July 16, 2024 19:09
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Thank you!

@jedel1043 jedel1043 requested a review from a team July 16, 2024 19:11
@jedel1043 jedel1043 added A-Enhancement New feature or request A-API Changes related to public APIs labels Jul 16, 2024
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@nekevss nekevss added this pull request to the merge queue Jul 19, 2024
Merged via the queue into boa-dev:main with commit d8b8066 Jul 19, 2024
@hansl hansl deleted the js_error branch July 19, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-API Changes related to public APIs A-Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants