Skip to content

Add a JsError::from_rust constructor to create native errors from Rust#3921

Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom
hansl:js_error_from_std
Aug 3, 2024
Merged

Add a JsError::from_rust constructor to create native errors from Rust#3921
jedel1043 merged 2 commits intoboa-dev:mainfrom
hansl:js_error_from_std

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Jul 16, 2024

No description provided.

@codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.56%. Comparing base (6ddc2b4) to head (7243dd3).
Report is 222 commits behind head on main.

Files Patch % Lines
core/engine/src/error.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3921      +/-   ##
==========================================
+ Coverage   47.24%   51.56%   +4.32%     
==========================================
  Files         476      468       -8     
  Lines       46892    44965    -1927     
==========================================
+ Hits        22154    23188    +1034     
+ Misses      24738    21777    -2961     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad
Copy link
Member

raskad commented Aug 1, 2024

I like the addition. What do you think about the name from_rust instead of from_std? I think Error is moving to core so eventually we could switch that type over without changing the name.

@raskad raskad added this to the next-release milestone Aug 1, 2024
@raskad raskad added A-Enhancement New feature or request A-API Changes related to public APIs labels Aug 1, 2024
@hansl
Copy link
Contributor Author

hansl commented Aug 2, 2024

@raskad I made the change, PTAL.

@hansl hansl changed the title Add a JsError::from_std constructor to create native errors from Rust Add a JsError::from_rust constructor to create native errors from Rust Aug 2, 2024
@raskad raskad requested a review from a team August 2, 2024 21:06
@jedel1043 jedel1043 added this pull request to the merge queue Aug 3, 2024
Merged via the queue into boa-dev:main with commit 6f1d7d1 Aug 3, 2024
@hansl hansl deleted the js_error_from_std branch August 3, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-API Changes related to public APIs A-Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants