Allow a custom Logger to be used as the backend for boa_runtime::Console#3943
Merged
jedel1043 merged 2 commits intoboa-dev:mainfrom Aug 14, 2024
Merged
Allow a custom Logger to be used as the backend for boa_runtime::Console#3943jedel1043 merged 2 commits intoboa-dev:mainfrom
jedel1043 merged 2 commits intoboa-dev:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
+ Coverage 47.24% 51.44% +4.19%
==========================================
Files 476 468 -8
Lines 46892 45168 -1724
==========================================
+ Hits 22154 23235 +1081
+ Misses 24738 21933 -2805 ☔ View full report in Codecov by Sentry. |
jasonwilliams
approved these changes
Aug 11, 2024
Member
jasonwilliams
left a comment
There was a problem hiding this comment.
LGTM (apart from comment), thanks @hansl
Contributor
Author
|
I made the change, PTAL. Sorry I asked for a re-review from @jedel1043 by mistake. |
jedel1043
approved these changes
Aug 14, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some cleanup that could be done in the number of lines of codes, but this was the smallest change I could do to make the change.
This comes from a need to implement
Consolewith usingtracingas the backend. Please note that there is an issue here where multiple logs in the same function (e.g.console.trace()) would output into multiple log entries. This should probably be fixed in a following PR (as this one is already large enough).