Add a display type for JsString to allow formatting without allocations#3951
Merged
HalidOdat merged 16 commits intoboa-dev:mainfrom Sep 9, 2024
Merged
Add a display type for JsString to allow formatting without allocations#3951HalidOdat merged 16 commits intoboa-dev:mainfrom
HalidOdat merged 16 commits intoboa-dev:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
==========================================
+ Coverage 47.24% 51.32% +4.08%
==========================================
Files 476 469 -7
Lines 46892 45228 -1664
==========================================
+ Hits 22154 23215 +1061
+ Misses 24738 22013 -2725 ☔ View full report in Codecov by Sentry. |
jasonwilliams
approved these changes
Aug 14, 2024
jasonwilliams
added
A-Performance
HalidOdat
approved these changes
Aug 17, 2024
Member
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Nice addition, looks good to me! :)
HalidOdat
requested changes
Aug 17, 2024
HalidOdat
approved these changes
Sep 9, 2024
Member
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Besides the minor nitpicks this looks good to me! :)
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Contributor
Author
|
@HalidOdat merged those three, don't know why I split the write in two with unpaired surrogates. |
hansl
added a commit
to hansl/boa
that referenced
this pull request
Sep 12, 2024
…ns (boa-dev#3951) Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting this into its own PR as the other PR was getting too large and opinionated. This should be fairly straightforward.