Build out partial record functionality, property bag construction, and with methods#3955
Merged
Build out partial record functionality, property bag construction, and with methods#3955
with methods#3955Conversation
Test262 conformance changes
Fixed tests (136): |
HalidOdat
approved these changes
Aug 17, 2024
Member
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Nice work!
Just some very minor nitpicks :)
nekevss
force-pushed
the
impl-with-and-fields
branch
from
936e3bc to
2283bc7
Compare
raskad
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to the ongoing work for temporal, specifically in relation to the
withmethods and partial records.It changes the following:
maponJsValueto_partial_date_recordandto_partial_time_recordwithmethods onTimeandDatealong with the property bags portions ofto_dateandto_timeabstract methodsI totally blanked on making the fields of
PartialDateTimepublic 😅 So that will hopefully still be coming after a patch I submitted is merged.