Remove leftover eprintln from JsPromise::await_blocking#3966
Closed
hansl wants to merge 1 commit intoboa-dev:mainfrom
Closed
Remove leftover eprintln from JsPromise::await_blocking#3966hansl wants to merge 1 commit intoboa-dev:mainfrom
hansl wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
==========================================
+ Coverage 47.24% 52.06% +4.81%
==========================================
Files 476 468 -8
Lines 46892 45100 -1792
==========================================
+ Hits 22154 23480 +1326
+ Misses 24738 21620 -3118 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Actually did make it a lint error in #3967. Closing this as duplicate work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should make this a lint error.