Add a clone_inner method to allow cloning of inner data#3968
Merged
nekevss merged 3 commits intoboa-dev:mainfrom Aug 27, 2024
Merged
Add a clone_inner method to allow cloning of inner data#3968nekevss merged 3 commits intoboa-dev:mainfrom
nekevss merged 3 commits intoboa-dev:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3968 +/- ##
==========================================
+ Coverage 47.24% 51.86% +4.61%
==========================================
Files 476 468 -8
Lines 46892 45295 -1597
==========================================
+ Hits 22154 23490 +1336
+ Misses 24738 21805 -2933 ☔ View full report in Codecov by Sentry. |
jedel1043
reviewed
Aug 23, 2024
Member
jedel1043
left a comment
There was a problem hiding this comment.
Looks great! I Just have a small doc nitpick.
jedel1043
approved these changes
Aug 26, 2024
nekevss
approved these changes
Aug 27, 2024
hansl
added a commit
to hansl/boa
that referenced
this pull request
Sep 12, 2024
* Add a clone_inner method to allow cloning of inner data * oops * Address comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue I'm looking to solve is that I'm passing back the same object into JavaScript (think callbacks). The object is reentrant safe, but I'm ending up doing a lot of
this.borrow().clone(). This would make it a bit easier to manage.The JS code looks like that: