Add TextEncoder, TextDecoder implementations to boa_runtime#3994
Merged
raskad merged 3 commits intoboa-dev:mainfrom Sep 19, 2024
Merged
Add TextEncoder, TextDecoder implementations to boa_runtime#3994raskad merged 3 commits intoboa-dev:mainfrom
raskad merged 3 commits intoboa-dev:mainfrom
Conversation
hansl
changed the title
jedel1043
approved these changes
Sep 15, 2024
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Looks great! Seeing that we'll keep increasing the number of WebAPI things in boa_runtime maybe it'll be worth adding a global function boa_runtime::register to add all the builtins into the global object.
jedel1043
added
A-Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.