Merged
Conversation
jasonwilliams
requested review from
HalidOdat,
RageKnify,
jedel1043,
nekevss and
raskad
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4026 +/- ##
==========================================
+ Coverage 47.24% 52.91% +5.66%
==========================================
Files 476 483 +7
Lines 46892 46893 +1
==========================================
+ Hits 22154 24813 +2659
+ Misses 24738 22080 -2658 ☔ View full report in Codecov by Sentry. |
jedel1043
reviewed
Nov 3, 2024
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Looks great, the file just needs a newline at the end 😅
jedel1043
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3910