Skip to content

Bug fix: regex started with /= parsed as AssignDiv#4048

Merged
jedel1043 merged 3 commits intoboa-dev:mainfrom
Nikita-str:bug-fix--reg-exp-div-assign-start
Dec 5, 2024
Merged

Bug fix: regex started with /= parsed as AssignDiv#4048
jedel1043 merged 3 commits intoboa-dev:mainfrom
Nikita-str:bug-fix--reg-exp-div-assign-start

Conversation

@Nikita-str
Copy link
Contributor

This Pull Request closes #3329

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (6ddc2b4) to head (2db3be3).
Report is 309 commits behind head on main.

Files with missing lines Patch % Lines
core/parser/src/lexer/mod.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4048      +/-   ##
==========================================
+ Coverage   47.24%   52.94%   +5.70%     
==========================================
  Files         476      483       +7     
  Lines       46892    46952      +60     
==========================================
+ Hits        22154    24859    +2705     
+ Misses      24738    22093    -2645     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team November 21, 2024 05:18
@nekevss nekevss added C-Parser Issues surrounding the parser lexer labels Nov 21, 2024
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, I just have one question about one test.

@raskad raskad added this to the v0.20.0 milestone Dec 5, 2024
@raskad raskad requested a review from a team December 5, 2024 19:36
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@jedel1043 jedel1043 modified the milestones: v0.20.0, next-release Dec 5, 2024
@jedel1043 jedel1043 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into boa-dev:main with commit c2e8d1f Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Parser Issues surrounding the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RegExp /=/ not parsed as such in certain locations

4 participants