Add valueOf methods to the Temporal builtins#4079
Merged
Conversation
Test262 conformance changes
Fixed tests (227):Broken tests (137): |
nekevss
added
A-Enhancement
hansl
approved these changes
Dec 11, 2024
Contributor
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Is there or should there be an issue/task for adding a proper valueOf implementation?
Member
Author
What do you mean by proper There's not a specific issue open, but there is a host of tracking issues that this would complete the Boa implementation for those issues. I believe this should be to spec for the Temporal proposal. |
raskad
reviewed
Dec 11, 2024
Contributor
Don't mind me, I was not looking at the right spec. |
nekevss
force-pushed
the
impl-temporal-valueof-methods
branch
from
a08d0e6 to
e2942df
Compare
jedel1043
reviewed
Dec 11, 2024
|
|
||
| pub(crate) fn value_of(_this: &JsValue, _: &[JsValue], _: &mut Context) -> JsResult<JsValue> { | ||
| Err(JsNativeError::typ() | ||
| .with_message("valueOf not implemented for Temporal objects. See 'compare', 'equals', or `toString`") |
Member
There was a problem hiding this comment.
Hmm, I'm a bit negative about the "not implemented" phrasing because it seems like we haven't implemented it yet. Maybe something like "valueOf is not supported on Temporal objects".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is related to the general work on #1804
It changes the following:
prototype.valueOfmethod implementation to the Temporal builtins