Skip to content

Add a stress test to the parser to parser multi-millions tokens#4086

Merged
hansl merged 1 commit intoboa-dev:mainfrom
hansl:issue-162
Dec 14, 2024
Merged

Add a stress test to the parser to parser multi-millions tokens#4086
hansl merged 1 commit intoboa-dev:mainfrom
hansl:issue-162

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Dec 13, 2024

This should prevent regressions over parsing large expressions.

Closes #162.

@hansl hansl requested a review from a team December 13, 2024 21:43
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (6ddc2b4) to head (27ba52f).
Report is 318 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4086      +/-   ##
==========================================
+ Coverage   47.24%   53.14%   +5.90%     
==========================================
  Files         476      484       +8     
  Lines       46892    48223    +1331     
==========================================
+ Hits        22154    25630    +3476     
+ Misses      24738    22593    -2145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hopefully we won't break the parser again 😅

@hansl hansl enabled auto-merge December 14, 2024 02:54
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hansl hansl added this pull request to the merge queue Dec 14, 2024
Merged via the queue into boa-dev:main with commit e529d70 Dec 14, 2024
@hansl hansl deleted the issue-162 branch December 14, 2024 06:54
@raskad raskad added the C-Parser Issues surrounding the parser label Dec 14, 2024
@raskad raskad added this to the next-release milestone Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Parser Issues surrounding the parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing an expression containing a huge list of token triggers a stack overflow

4 participants