Skip to content

Allow local parameters if mapped arguments object is not used#4092

Merged
raskad merged 2 commits intomainfrom
local-parameters-if-mapped-arguments-object-not-accessed
Feb 15, 2025
Merged

Allow local parameters if mapped arguments object is not used#4092
raskad merged 2 commits intomainfrom
local-parameters-if-mapped-arguments-object-not-accessed

Conversation

@raskad
Copy link
Member

@raskad raskad commented Dec 23, 2024

This Pull Request changes the following:

  • Allow local parmeters if mapped arguments object is not used
  • Add tests for scopes in boa_ast

@github-actions
Copy link

github-actions bot commented Dec 23, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,133 46,133 0
Ignored 1,634 1,634 0
Failed 2,487 2,487 0
Panics 0 0 0
Conformance 91.80% 91.80% 0.00%

@raskad raskad added this to the next-release milestone Dec 23, 2024
@raskad raskad added the C-AST Issue surrounding the abstract syntax tree label Dec 23, 2024
@raskad raskad requested a review from a team December 23, 2024 03:32
@jedel1043 jedel1043 changed the title Allow local parmeters if mapped arguments object is not used Allow local parameters if mapped arguments object is not used Dec 23, 2024
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization!

@jedel1043 jedel1043 requested a review from a team December 23, 2024 18:02
@nekevss nekevss added this pull request to the merge queue Feb 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2025
@raskad raskad force-pushed the local-parameters-if-mapped-arguments-object-not-accessed branch from 2757dec to cf506ee Compare February 15, 2025 19:36
@raskad raskad added this pull request to the merge queue Feb 15, 2025
Merged via the queue into main with commit c14e99c Feb 15, 2025
14 checks passed
@raskad raskad deleted the local-parameters-if-mapped-arguments-object-not-accessed branch May 30, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-AST Issue surrounding the abstract syntax tree

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants