Bump the temporal_rs version and related changes#4098
Merged
Conversation
Test262 conformance changes
Fixed tests (109):Broken tests (15): |
Member
|
Nice! Any reasons for the regressions? or are they just false positives? Also, do we want to bump test262 to pull the latest Temporal tests? |
Member
Author
|
At a glance of the tests names, most if not all are going to be false positives from removing the not implemented errors, so I'd prefer to move along with these as is. Although, I'll probably start tracking the tests broken and PR # for future use as I'm starting to switch a bit more into bug hunting to shore up the tests. I can bump the tests. |
nekevss
force-pushed
the
bump-temporal-version
branch
from
4f436b6 to
94f15a5
Compare
Member
|
Oof, those are a lot more failures than expected. I suppose those are the new spidermonkey tests that were imported. Can you check why they're failing? If it's something engine-dependent, it would be good to gate the tests. |
Member
|
By the way, if it's getting too unwieldy for a single PR, I think it would be good to split the test262 bump into its own PR. |
Member
Author
|
Hmmmm, I think I'd prefer to do it in a separate PR just for the separation of concerns. I was already leaning towards splitting them off last night. I'll just move them over to another branch and push that up. |
nekevss
force-pushed
the
bump-temporal-version
branch
from
8461835 to
33107af
Compare
jedel1043
approved these changes
Dec 27, 2024
| Err(JsNativeError::error() | ||
| .with_message("not yet implemented.") | ||
| .into()) | ||
| fn zoneddatetime(_: &JsValue, args: &[JsValue], context: &mut Context) -> JsResult<JsValue> { |
Member
There was a problem hiding this comment.
Thought: not gonna bikeshed because I think it's not worth for internal APIs, but we should probably do a pass through our names to agree on at least a "convention" .
Member
Author
There was a problem hiding this comment.
Yeah, I've been wanting to open an issue to go over naming conventions in temporal_rs for a few weeks now. Would be handy for Boa too
raskad
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is related to ongoing work for #1804
This is a general bump in the
temporal_rsversion that implementsZonedDateTimefor duration rounding, updates the general API, build out of the remainingNowmethods, and a couple other fixes.Some other changes made in this PR are:
static_propertyattribute flagsepochMillisecondsandepochNanosecondsPlainDatemodule