Set the array "length" property in [[DefineOwnProperty]] based on the array shape#4101
Merged
Set the array "length" property in [[DefineOwnProperty]] based on the array shape#4101
[[DefineOwnProperty]] based on the array shape#4101Conversation
Test262 conformance changes
|
Member
Author
|
As you can see the Before: RESULT Richards 131
RESULT DeltaBlue 115
RESULT Crypto 120
RESULT RayTrace 277
RESULT EarleyBoyer 365
RESULT RegExp 64.1
RESULT Splay 525
RESULT NavierStokes 341
SCORE 195After: RESULT Richards 132
RESULT DeltaBlue 114
RESULT Crypto 118
RESULT RayTrace 276
RESULT EarleyBoyer 367
RESULT RegExp 62.5
RESULT Splay 672
RESULT NavierStokes 340
SCORE 200 |
HalidOdat
approved these changes
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimization is especially useful for array literal construction. Instead of calling
OrdinaryGetOwnPropertyandOrdinaryDefineOwnPropertyon the array object while setting the "length" property, all of that can be skipped if the shape of the array has not changed.