Skip to content

Remove some clones and branches in hot PropertyDescriptor functions#4104

Merged
jedel1043 merged 1 commit intomainfrom
prop-desc-opt
Dec 30, 2024
Merged

Remove some clones and branches in hot PropertyDescriptor functions#4104
jedel1043 merged 1 commit intomainfrom
prop-desc-opt

Conversation

@raskad
Copy link
Member

@raskad raskad commented Dec 30, 2024

This Pull Request changes the following:

  • Avoid cloning values in PropertyDescriptor functions.
  • Avoid some matches in PropertyDescriptor functions.

@raskad raskad added performance Performance related changes and issues execution Issues or PRs related to code execution labels Dec 30, 2024
@raskad raskad added this to the next-release milestone Dec 30, 2024
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 43,947 43,947 0
Ignored 3,096 3,096 0
Failed 3,211 3,211 0
Panics 0 0 0
Conformance 87.45% 87.45% 0.00%

@raskad raskad requested a review from a team December 30, 2024 20:30
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedel1043 jedel1043 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 13344ce Dec 30, 2024
13 checks passed
@jedel1043 jedel1043 deleted the prop-desc-opt branch December 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execution Issues or PRs related to code execution performance Performance related changes and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants