Skip to content

Use cow-utils instead#4133

Merged
raskad merged 4 commits intoboa-dev:mainfrom
heygsc:feat/cow
Jan 18, 2025
Merged

Use cow-utils instead#4133
raskad merged 4 commits intoboa-dev:mainfrom
heygsc:feat/cow

Conversation

@heygsc
Copy link
Contributor

@heygsc heygsc commented Jan 14, 2025

close: #4123

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.76%. Comparing base (6ddc2b4) to head (b73c9f3).
Report is 349 commits behind head on main.

Files with missing lines Patch % Lines
core/macros/src/lib.rs 0.00% 5 Missing ⚠️
core/engine/src/builtins/string/mod.rs 0.00% 2 Missing ⚠️
.../engine/src/builtins/temporal/zoneddatetime/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4133      +/-   ##
==========================================
+ Coverage   47.24%   53.76%   +6.51%     
==========================================
  Files         476      485       +9     
  Lines       46892    48456    +1564     
==========================================
+ Hits        22154    26050    +3896     
+ Misses      24738    22406    -2332     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyboyQCD
Copy link
Contributor

CrazyboyQCD commented Jan 15, 2025

Please wait for #4134 to get merged, so that to_string could be removed on those conversions to avoid one extra allocation.

@nekevss nekevss requested a review from a team January 16, 2025 19:57
@nekevss nekevss added the A-Internal Changes that don't modify execution behaviour label Jan 16, 2025
@nekevss nekevss requested a review from a team January 18, 2025 17:47
@raskad raskad added this to the next-release milestone Jan 18, 2025
@raskad raskad added this pull request to the merge queue Jan 18, 2025
Merged via the queue into boa-dev:main with commit 718dfd9 Jan 18, 2025
@heygsc heygsc deleted the feat/cow branch January 22, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Internal Changes that don't modify execution behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: use cow-utils instead

5 participants