Skip to content

Bump temporal_rs to Feb. 15 version + adjustments#4162

Merged
jasonwilliams merged 1 commit intomainfrom
bump-temporal-2-15
Feb 16, 2025
Merged

Bump temporal_rs to Feb. 15 version + adjustments#4162
jasonwilliams merged 1 commit intomainfrom
bump-temporal-2-15

Conversation

@nekevss
Copy link
Member

@nekevss nekevss commented Feb 15, 2025

This Pull Request is related to the ongoing work for #1804

This most recent version includes some bug fixes along with some API changes to Now in temporal_rs. Changes were made to accommodate the Now changes.

@github-actions
Copy link

github-actions bot commented Feb 15, 2025

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 46,133 46,211 +78
Ignored 1,634 1,634 0
Failed 2,487 2,409 -78
Panics 0 0 0
Conformance 91.80% 91.95% +0.16%
Fixed tests (79): 
test/intl402/Temporal/PlainDateTime/from/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/until/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/since/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/equals/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/withCalendar/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/withCalendar/argument-string.js (previously Failed)
test/intl402/Temporal/PlainDate/from/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/until/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/since/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/equals/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/withCalendar/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/from/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/until/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/since/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/equals/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withCalendar/basic.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withCalendar/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withCalendar/calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-calendar-wrong-type.js (previously Failed)
Broken tests (1): 
test/intl402/Temporal/PlainMonthDay/prototype/with/fields-missing-properties.js (previously Passed)

@nekevss nekevss requested a review from a team February 15, 2025 20:44
@nekevss nekevss added the C-Builtins PRs and Issues related to builtins/intrinsics label Feb 15, 2025
@jedel1043
Copy link
Member

jedel1043 commented Feb 16, 2025 •
edited
Loading

Nice! Is the broken test expected breakage?

@nekevss
Copy link
Member Author

nekevss commented Feb 16, 2025

It's not expected breakage, but I do think that it may have been a false positive on the test case.

The bumps included in this PR are the Now changes and the Calendar parsing fix (where all the fixed tests are from). Only the latter is called on the code for the broken test.

jedel1043
jedel1043 approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case, this looks good for me.

@jedel1043 jedel1043 requested a review from a team February 16, 2025 04:47
@jasonwilliams jasonwilliams added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit a8aea9c Feb 16, 2025
14 checks passed
@jasonwilliams jasonwilliams deleted the bump-temporal-2-15 branch February 16, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees

No one assigned

Labels

C-Builtins PRs and Issues related to builtins/intrinsics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nekevss @jedel1043 @jasonwilliams